1688790 - Migrate StartupCache bytecode format to Stencil-XDR

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

Remove the use of EncodeScript and instead using Stencil-XDR APIs. This requires converting from post-execution encoding to incremental mode, but full-parsing is always used with these caches so this is not a big hurdle.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1688790 - Migrate StartupCache bytecode format to Stencil-XDR r?kmag,arai

Depends on D103830

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1688790 - Clean up TryCacheLoadAndCompileScript r?kmag!

Remove always-true parameter to TryCacheLoadAndCompileScript, and don't consult
ScriptPreloader for loads that will never hit due to incorrect schema.

Depends on D103708

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1688790 - Make TranscodeRange use a const type param r?arai

Depends on D113010

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1688790 - Convert startup cache to managing stencils not scripts r?kmag!

Note: The stencil will hold pointers into the StartupCache buffer;
There is an assumption in this patch that the lifetime of the buffer
is long enough that we can compile the stencil without causing issues.

Note, we have ot adjust the test_source-03 expectation. Since we no longer
cache scripts, and instead cache stencils, it's not guaranteed the scripts
will have identical ScriptSourceObjects.

Depends on D113011

Comment 5

[BugBot [:suhaib / :marco]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:mgaudet, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

Due to some startup performance concerns we plan to sit on this for a bit.

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1688790 - Clean up conditions for storing cache into the preloader into the startup cache r?kmag!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86ca7b7b35de
Clean up conditions for storing cache into the preloader into the startup cache r=kmag,tcampbell
https://hg.mozilla.org/integration/autoland/rev/14afba0107e7
Clean up TryCacheLoadAndCompileScript r=kmag,tcampbell
https://hg.mozilla.org/integration/autoland/rev/7c00354ac078
Convert startup cache to managing stencils not scripts r=kmag,tcampbell

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/86ca7b7b35de
https://hg.mozilla.org/mozilla-central/rev/14afba0107e7
https://hg.mozilla.org/mozilla-central/rev/7c00354ac078