Closed Bug 1688812 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27323 - [selectors] Fix leaks on focus-visible-{007,013}.html tests

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27323 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27323
Details from upstream follow.

b'Manuel Rego Casasnovas <rego@igalia.com>' wrote:

[selectors] Fix leaks on focus-visible-{007,013}.html tests

These tests are using test_driver.click() which has a known issue,
see bug #1164600. This is a similar fix to r841432 that fixed leaks
in other :focus-visible tests.

Bug: 976438
Change-Id: I3a17fcccf8d8c01f2259b965f63df3d4ff521bad
Cq-Include-Trybots: luci.chromium.try:layout_test_leak_detection,leak_detection_linux
Reviewed-on: https://chromium-review.googlesource.com/2648468
WPT-Export-Revision: 647e7f46d034424ae1a459e2f26559901aef6900

PR 27323 applied with additional changes from upstream: 99d6748c72fc6b6cbf72d656228ac826a6edb07c, 82877d9297125b49ce24a1404f7413786a27ffae
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS : 1
FAIL : 1

Chrome

OK : 2
PASS : 2

Safari

OK : 1
FAIL : 2
TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/selectors/focus-visible-007.html
Using keyboard while element is focused should trigger :focus-visible; using mouse without moving focus should not cancel it; moving focus using mouse should cancel it.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e103f08216bc
[wpt PR 27323] - [selectors] Fix leaks on focus-visible-{007,013}.html tests, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e103f08216bc

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.