1688851 - [Linux/EGL] Use gbm_bo_create instead of gbm_bo_create_with_modifiers if all modifiers are set to DRM_FORMAT_MOD_INVALID

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Robert Mader [:rmader]]

This would stop mesa from spamming Only invalid modifier specified to stderr when running e.g. WebGL with DMABUFs on Mutter/Wayland.

See https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7601#note_778855 for context.

Comment 1

[Robert Mader [:rmader]]

Martin, needinfoing you here so you know about it.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Okay, I think the fix may be easy. We just need to scan the format modifiers and remove them when they're invalid. That can be done at nsDMABufDevice::nsDMABufDevice() where the format modifiers are loaded.

Comment 3

[Robert Mader [:rmader]]

Attachment: Bug 1688851 - Check if modifiers are valid before adding. r=stransky

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9562386904cc
Check if modifiers are valid before adding. r=stransky,jgilbert

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9562386904cc