1688910 - Replace direct use of barrier tracer with calls to barrier functions

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task)

Description

[Jon Coppeard (:jonco)]

There are a few places where we perform barriers using the barrier tracer directly (e.g. calling TraceEdge or traceChildren methods with it as an argument) rather than calling one of the barrier functions.

This has two problems:

• it has to dispatch on the tracer kind even though it's known in advance
• it skips the assertions in the barrier functions

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1688910 - Add an API for performing write barriers on structures that have GC thing children r?jandem

This adds an API for the case where we need to barrier all the edges out of a structure. This reduces direct usage of the barrier tracer and adds the assertions that are present in calls to the barrier functions.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1688910 - Call barrier functions rather than using barrier tracer for JIT barriers r?jandem

This avoids dispatching on the known tracer kind.

Depends on D103054

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc6967c473c6
Add an API for performing write barriers on structures that have GC thing children r=jandem
https://hg.mozilla.org/integration/autoland/rev/d884487b2661
Call barrier functions rather than using barrier tracer for JIT barriers r=jandem

Comment 4

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1688910) for Spidermonkey failure in /checkouts/gecko/js/src/gc/WeakMap.h. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=327974455&repo=autoland&lineNumber=3067

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=T4ZjZUUFSeOdLQ6GHzocjw.0&revision=d884487b26614f102c01fc36ac59b01ba8a4400f

Backout:
https://hg.mozilla.org/integration/autoland/rev/7d77704e9bc90f9d4df323d47759e948b78b9439

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ff5310b9fa0
Add an API for performing write barriers on structures that have GC thing children r=jandem
https://hg.mozilla.org/integration/autoland/rev/68057585ebe7
Call barrier functions rather than using barrier tracer for JIT barriers r=jandem

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1ff5310b9fa0
https://hg.mozilla.org/mozilla-central/rev/68057585ebe7