1688942 - Highlighted tiles in the new tab no longer have focus styling.

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

As brought up by @prathiksha and @JulianWels , there is no focus styling that is visible when tabbing to a highlighted tiles right under the search area. The pocket tiles still seem to have the styling. This is not the case without the newnew tab pref so it seems like a recent regression.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:yzen, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 2

[Scott [:thecount] Downe]

I cannot reproduce, is there something special I need to set to see this?

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

You'd need the new new tab pref set - browser.newtabpage.activity-stream.newNewtabExperience.enabled and if on Mac enable this System pref:
System Preferences -> Keyboard -> Shortcuts -> Use keyboard navigation to move focus between controls needs to be checked

Comment 4

[Erica Wright [:ewright]]

Attachment: Bug 1688942 - Fix newtabExperience focus highlights

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b9d369e4a68
Fix newtabExperience focus highlights r=prathiksha,JulianWels

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2b9d369e4a68

Comment 7

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the TopSites are correctly highlighted while focused using keyboard navigation using Firefox Nightly 87.0a1 (Build ID: 20210208092848) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64.

Comment 8

[Erica Wright [:ewright]]

Comment on attachment 9200153 [details]
Bug 1688942 - Fix newtabExperience focus highlights

Beta/Release Uplift Approval Request

• User impact if declined: users involved in our experiments in 86 will not have a proper focus highilght effect on topsites, pocket, and highlights.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS patch, all behind a pref.
• String changes made/needed: none

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9200153 [details]
Bug 1688942 - Fix newtabExperience focus highlights

Low risk, approved for 86 beta 8, thanks.

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3966ce93c2b3

Comment 11

[Robert Martin [:romartin], Ecosystem QA]

Hey @Erica,

I've checked the issue in the latest Firefox Beta 86.0b8 (Build ID: 20210209185733) and I seem to reproduce it on Windows 10 x64, macOS 10.15, and Ubuntu Linux 20.04 x64. Can you please weigh in on this?

STR:

1. Open Firefox Beta 86.0b8 browser.
2. Navigate to the "about:config" page.
3. Set the "browser.newtabpage.activity-stream.newNewtabExperience.enabled" pref value to "true".
4. Open a "New Tab" page.
5. Click the "Personalize" button located in the top right corner of the page.
6. Select the "1 row" dropdown-menu under the "Shortcuts" section using keyboard navigation and observe the highlight style.

Comment 12

[Erica Wright [:ewright]]

@Robert, it seem you are describing Bug 1688414, which was not uplifted to beta, but should be fixed in 87.

Comment 13

[Robert Martin [:romartin], Ecosystem QA]

Hey Erica,

You are completely correct. Thank you for pointing that out for me!
That being said, I have verified that the TopSites are correctly highlighted while focused using keyboard navigation using Firefox Beta 86.0b8 (Build ID: 20210209185733) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64.