1688960 - Accessibility improvements for App Menu sub-menus.

Status: RESOLVED FIXED

(Firefox :: Menus, enhancement)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

There are a couple of accessibility improvements that can be made to make our accessibility users experience even more delightful. We currently have what can be described as top level headings and lower level headings within sub-menus. For example "More tools" is the top level heading for that menu and "Browser tools" is a lower level heading for the menu items that are grouped together.

• semantically these should really be headings, and can either be implemented as <hX> (preferred) or, alternatively, using ARIA role="heading" and aria-level="X"
• these headings should be attached to elements of the menu that they are descibing:
  • the top level heading's ID should be used as the value of aria-labelledby attribute on the menu itself.
  • the lower level heading's ID should be used as the value of aria-labelledby attribute on the container element that contains that group's menu items (currently they are all flattened)
    • the above container should have role="group"

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1688960 - Use h1 and h2 elements for panel headers and subheaders. r?Standard8!,yzen!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a34474998cd6
Use h1 and h2 elements for panel headers and subheaders. r=Standard8,yzen,fluent-reviewers,flod

Comment 3

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1688960, bug 1693177) for Browser-chrome failures in browser/base/content/test/sync/browser_sync.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=330965940&repo=autoland&lineNumber=2472

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=13e08408add01b5e1333ee0abcaa1fd807e6e1c8

Backout:
https://hg.mozilla.org/integration/autoland/rev/96a5b22dd961fd0b463ae5ecf6948b1fdd3f9fe1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2560f3f055fd
Use h1 and h2 elements for panel headers and subheaders. r=Standard8,yzen,fluent-reviewers,flod

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2560f3f055fd