1689005 - [wpt-sync] Sync PR 27338 - Remove <popup> "open" content attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27338 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27338
Details from upstream follow.

b'Mason Freed <[e-mail]>' wrote:

Remove <popup> "open" content attribute

This converts the usage of \<popup open> to a WebIDL-only boolean
attribute. There will not be an "open" content attribute; the
visibility of the \<popup> will be solely controllable through
the .show() and .hide() APIs.

In conjunction with removing the "open" attribute, this CL also
overrides the computed style for the "display" property for
popups, so that authors cannot cascade "display: block" onto a
\<popup> and get it to be visible.

Bug: 1168738
Fixed: 1169784
Change-Id: Ie3d903a3a7f4e1cc0245ca819f036d00c194cbe0
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/2648613
WPT-Export-Revision: 6d52f1526962fd4ee5aaacbf72eb06b386a4e99b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 27338 applied with additional changes from upstream: 76a0658b54cd51506018989fb6753f9becbd1a82

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc642b3c5f8898f97fde93f1cad9ee2729246407

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

OK : 1
FAIL: 5

Chrome

OK : 1
FAIL: 5

Safari

OK : 1
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/interactive-elements/the-popup-element/popup-element-basic.tentative.html
popup element exists: FAIL (Chrome: FAIL, Safari: FAIL)
The IDL "open" content attribute must have no effect, and must not be reflected to the WebIDL.: FAIL (Chrome: FAIL, Safari: FAIL)
The only visibility control for <popup> is through .show() and .hide().: FAIL (Chrome: FAIL, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-hidden-display.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-open-display.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34372466b901
[wpt PR 27338] - Remove <popup> "open" content attribute, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e0de68a404d7
[wpt PR 27338] - Update wpt metadata, a=testonly

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/34372466b901
https://hg.mozilla.org/mozilla-central/rev/e0de68a404d7