1689028 - File Picker and emoji picker do not respect macOS darkmode

Status: RESOLVED DUPLICATE of bug 1702351

(Core :: Widget: Cocoa, defect, P2)

Description

[WIlliam Davis [:AwesomeSheep48]]

Attachment: Screen Shot 2021-01-26 at 8.00.26 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 11.1; rv:86.0) Gecko/20100101 Firefox/86.0

Steps to reproduce:

Press cmd+O or go to a website where you upload a file and press upload.

For the emoji picker press the function key to open the emoji picker while in the firefox app.

Actual results:

They show up in lightmode despite macOS and Firefox are in darkmode.

Expected results:

They show up in darkmode while macOS and Firefox are in darkmode.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[WIlliam Davis [:AwesomeSheep48]]

Attachment: Screen Shot 2021-01-28 at 1.14.02 AM.png

Another thing affected by this

Comment 3

[Stephen A Pohl [:spohl]]

This should get addressed by bug 1623686.

Comment 4

[WIlliam Davis [:AwesomeSheep48]]

(In reply to Stephen A Pohl [:spohl] from comment #3)

This should get addressed by bug 1623686.

I edited info.plist myself and it did fix it, though some other things got messed up.

Comment 5

[WIlliam Davis [:AwesomeSheep48]]

Was I supposed to close this issue?

Comment 6

[Markus Stange [:mstange]]

Oh, good point, better to keep this bug open until it's actually fixed in Firefox.

Comment 7

[WIlliam Davis [:AwesomeSheep48]]

This is fixed by enabling widget.macos.respect-system-appearance in the latest nightly

Comment 8

[Markus Stange [:mstange]]

This ended up being fixed by bug 1702351, so this is fixed in Firefox 89.