Closed Bug 1689115 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27351 - [testharness.js] Disable assert tracking on workers

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox87 fixed)

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27351 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27351
Details from upstream follow.

b'Stephen McGruer <smcgruer@chromium.org>' wrote:

[testharness.js] Disable assert tracking on workers

We are continuing to see a performance regression from assert tracking
in Chromium. After investigation, it appears that the root problem is
that there is no way currently for a testharness.js script loaded in a
worker to know that it shouldn't be tracking asserts (since
testharnessreport.js isn't loaded).

To fix the performance hit, this commit disables assert tracking
entirely in workers. This is a behavior regression for the feature, but
is necessary to avoid an unacceptable performance regression.

Associated Chromium bug: https://crbug.com/1170588

Whiteboard: [wptsync downstream] → [wptsync downstream error]
PR 27351 applied with additional changes from upstream: 9c225de1bd1c353b8eb58f17880a3841fea07ac5
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e2758d380d1
[wpt PR 27351] - [testharness.js] Disable assert tracking on workers, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3e2758d380d1

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.