1689119 - Fix potentially duplicated telemetry initialization in "LoginCSVImport.jsm"

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P2)

Description

[Tim Giles [:tgiles]]

Currently, we do not cancel the telemetry stopwatch if we throw any errors in LoginCSVImport.jsm. This seems like incorrect behavior and will cause the browser_openImportCSV.js test to fail when running the test in --verify mode.

The following are the errors that appear when running browser_openImportCSV.js in --verify mode:

browser/components/aboutlogins/tests/browser/browser_openImportCSV.js
  FAIL [JavaScript Error: "Error: TelemetryStopwatch: key "FX_MIGRATION_LOGINS_IMPORT_MS" was already initialized" {file: "resource://gre/modules/LoginCSVImport.jsm" line: 136}]
importFromCSV@resource://gre/modules/LoginCSVImport.jsm:136:24

resource://specialpowers/SpecialPowersChild.jsm:observe/<:158
  FAIL [JavaScript Error: "Error: TelemetryStopwatch: finishing nonexisting stopwatch. Histogram: "FX_MIGRATION_LOGINS_IMPORT_MS", key: "login_csv"" {file: "resource://gre/modules/LoginCSVImport.jsm" line: 222}]
importFromCSV@resource://gre/modules/LoginCSVImport.jsm:222:26

Comment 1

[Andrei Petcu]

Attachment: Bug 1689119 Fix potentially duplicated telemetry initialization in "LoginCSVImport.jsm"

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4947b0149aee
Fix potentially duplicated telemetry initialization in "LoginCSVImport.jsm" r=tgiles

Comment 3

[Andrei Petcu]

Why is this issue not closed/fixed or something? Does it need to be changed manually?

Comment 4

[Tim Giles [:tgiles]]

It hasn't landed on central yet, so it hasn't been resolved yet. Here's a different bug that shows that process happening

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4947b0149aee