1689155 - Focus ring on links after switching back to tabs after 85 update.

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Avlasenko Vitaliy]

Attachment: Снимок экрана 2021-01-27 184915.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

Open link on any site.

Actual results:

All links that was clicked has focus line (dotted box) on it. It happens only with Firefox and after 85 update. What is the purpose of this thing? It's pretty annoying to see it everytime.

Expected results:

I think this focus line should be disabled by default as it was earlier.

Comment 1

[Raluca Popovici, Desktop QA]

I was not able to reproduce this issue on my machine win 10x64 on Fx 85.0 (russian and english build).

Please test if the issue occurs in safe mode. Here is a link that can help you do that:
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

If the issue still persists, please test it using a new profile, you can find the steps to do that below:
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

Comment 2

[Avlasenko Vitaliy]

It's strange that you can't reproduce it because I met several people who also have this problem. I've tried to check it in safe mode and with new profile - it' doesn't help me. Also I want to note that it happens with all links in Firefox that was clicked, not only with search results.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Application Update' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

If you go to about:config, do you have layout.css.focus-visible.enabled=false by any chance? It should be true.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

If the answer is "yes", does a new profile show the same issue? It should not.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Ok, so this happened to a couple other people I found and they confirmed comment 4.

Bug 1690225 will "fix" this by removing the feature flag, but that's only on nightly at this point. With a bit of help from Jared we figured out what the issue is, which is basically bug 1692122...

Comment 7

[Emilio Cobos Álvarez (:emilio)]

So after some poking I'm not sure this really is bug 1692122... That'd explain the issue for the other people that I know suffered from this, which used Nightly, but not for you...

Comment 8

[Emilio Cobos Álvarez (:emilio)]

If the focus-visible pref is false, can you report the pref value of network.preload in about:config too? If that's also false then it might be related to the experimental features... otherwise probably it's something else, somehow.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

And alternatively, does this happen only when you switch back to a tab? If so, I can reproduce that, but that's different from what's described in comment 0.

Comment 10

[Avlasenko Vitaliy]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #9)

And alternatively, does this happen only when you switch back to a tab? If so, I can reproduce that, but that's different from what's described in comment 0.

Yes, it happen when I switch back. If I choose "open link in new tab" I don't have this ring.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Ah, ok, that's a different thing then, thanks for clarifying!

That happens because we re-focus the element when switching back to the tab. Since the focus is neither keyboard nor mouse triggered, it shows outlines per the focus-visible spec. But the refocus case is a bit special, let's see if we can handle it better.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1689155 - Shuffle a bit the focus ring code again. r=edgar

No behavior change, just moving the decision of whether to show outlines
to slightly earlier.

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1689155 - Don't necessarily show outlines on refocus. r=edgar

Preserve the last state of when we focused the element in that window,
if the focus method is unknown.

Depends on D104861

Comment 14

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

:emilio: feel free to change the severity.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78a47c967db3
Shuffle a bit the focus ring code again. r=edgar
https://hg.mozilla.org/integration/autoland/rev/bf4ed0fa612b
Don't necessarily show outlines on refocus. r=edgar

Comment 17

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1689155) for causing bc failures in browser_outline_refocus.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/fe1cbbdfc7166c0c70d9d304be193062e104ec36

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=6ee7daf9a461d51c9ef7b70e177074d2e568f30f&searchStr=bc&tochange=fe1cbbdfc7166c0c70d9d304be193062e104ec36&selectedTaskRun=EAD1nUw-TaWq47xGMTnyQA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=330010009&repo=autoland&lineNumber=18548

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef87cffe51c5
Shuffle a bit the focus ring code again. r=edgar
https://hg.mozilla.org/integration/autoland/rev/47cb19189a4a
Don't necessarily show outlines on refocus. r=edgar

Comment 19

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ef87cffe51c5
https://hg.mozilla.org/mozilla-central/rev/47cb19189a4a