Add a cloned content message resource
Categories
(DevTools :: Console, task)
Tracking
(Fission Milestone:M7, firefox87 fixed)
Tracking | Status | |
---|---|---|
firefox87 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(1 file)
While working on Bug 1642599, I encountered an issue where we didn't have a consoleApi
event listener anymore, which means we were missing cloned content messages when the devtools.browsertoolbox.fission
pref was not enabled.
This is because we start an old-school listener for those messages in https://searchfox.org/mozilla-central/rev/0dfbe5a699cc6c73cf8c14d1aa10ba10ef3ec8fa/devtools/client/webconsole/webconsole-connection-proxy.js#127 , and we need a way to listen for them.
The simplest solution seems to add a legacy-listener-only resource, that will take care of starting the listener and listening for new messages.
Assignee | ||
Comment 1•3 years ago
|
||
This is a legacy-listener-only resource that is required for us to receive the
messages cloned from the content process in the browser console when the devtools.browsertoolbox.fission
pref is not enabled.
Since the messages are sent through the consoleApiCall
event, we add a clonedFromContentProcess
flag so we can ignore legit console api messages, which are handled as another resource.
This let us remove the specific code in WebConnectionProxy.
Comment 2•3 years ago
|
||
Tracking dt-fission-m3-mvp feature bugs for Fission M7 (blocking Beta experiment).
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/241b91491e11 [devtools] Add cloned content process message resource. r=ochameau,devtools-backward-compat-reviewers.
Comment 4•3 years ago
|
||
bugherder |
Description
•