168930 - Cookie accept/decline alert buttons are in the wrong order

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect, P4)

Description

[Matthew T (active 1999-2002)]

Build: 2002091503, Mac OS 9.2.2

To reproduce:
1.  Set the pref to be asked whenever a new cookie is set (`Edit' >
    `Preferences...' > `Privacy & Security' > `Cookies' > `Ask me before storing
    a cookie'.
2.  Go to a Web page which tries to set a new cookie.
3.  Look at the alert.

What you should see:
*   The button for accepting the cookie should be in the corner of the alert.

What you actually see:
*   The button for accepting the cookie is second from the left.

This is contrary to the Human Interface Guidelines (the affirmative button
should be in the right corner). It is also the opposite of the previous
(correct) button ordering, so that people who routinely declined cookies will
now be accepting them by mistake, and vice versa.

Comment 1

[Darin Fisher]

-> suresh

Comment 2

[Suresh]

Attachment: screenshot with hidden details.

Comment 3

[Suresh]

Attachment: screenshot with all details.

Comment 4

[Suresh]

Attachment: patch attached

1. This patch makes Cookie accept dialog to be consistent with rest of the
mozilla dialogs, i.e Ok and Cancel buttons appears at the bottom.

2. Also, on mac it appears the correct way. (Cancel, OK).

Comment 5

[jag (Peter Annema)]

Comment on attachment 111639 [details] [diff] [review]
patch attached

sr=jag

Comment 6

[Suresh]

this is fixed in trunk.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

this caused bug 189522... please don't tell me that the change to "ok/cancel"
from "yes/no" is wanted...

Comment 8

[Matthias Versen [:Matti]]

Comment on attachment 111639 [details] [diff] [review]
patch attached

removing obso9lete review request

Comment 9

[benc]

V/fixed.
CFM RIP anyhow.

Comment 10

[benc]

V/fixed.
CFM RIP anyhow.