Closed Bug 1689304 Opened 4 months ago Closed 3 months ago

[Enhancement] Consider renaming the “Save Theme” button’s label with a more appropriate one since the Theme is already saved if the Theme card is clicked

Categories

(Firefox :: Messaging System, enhancement, P1)

Product:
Firefox
Component:
Messaging System
Platform:
Desktop
All
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
88 Branch
Iteration:
88.1 - Feb 22 - Mar 7
Tracking Flags:
Tracking Status
firefox85 --- wontfix
firefox86 --- wontfix
firefox87 --- wontfix
firefox88 --- verified

People

(Reporter: linda.marginean, Assigned: emcminn)

Details

Attachments

(2 files)

about welcome.gif
561.46 KB, image/gif
Details
Bug 1689304 - Update theme screen CTA string
48 bytes, text/x-phabricator-request
Details | Review
Attached image about welcome.gif —

[Affected Versions]:

  • Firefox Release 85.0 - Build ID: 20210118153634
  • Firefox Beta 86.0b2 - Build ID: 20210126185730
  • Firefox Nightly 87.0a1 - Build ID: 20210127093943

[Affected Platforms]:

  • Windows 10 (x64)
  • Ubuntu Linux 20.04 (x64)
  • macOS 10.15

[Prerequisites]:

  • Have a new clean Firefox Profile created.

[Steps to reproduce]:

  1. Start the Firefox Browser with the profile from prerequisites.
  2. Navigate to the “about:welcome” page and click the “Start Setup” button.
  3. Click the “Not now” button.
  4. Click a theme from the displayed theme tiles.
  5. Open a new tab and observe the change.

[Expected results]:

  • The selected theme should not be applied to the browser.

[Actual results]:

  • The selected theme should be applied to the browser.

[Notes]:

  • Considering that we could save any Theme without actually clicking the “Save Theme” button, we suggest replacing the button’s label with a more appropriate one.

Click of theme card installs theme to support theme preview and keeps theme installed if a user clicks on button 'Save Theme'. We are not guarding exit points and reverting back if a user exits without clicking Save Theme.

NI content for feedback if changing button copy to reflect 'Keep Theme' is a better user experience or leave it as is. Thanks

Flags: needinfo?(mwalkington)
Severity: -- → S4
Priority: -- → P2

Let's change the button copy to: Done

Flags: needinfo?(mwalkington)

Moving back to triage

Priority: P2 → --
Assignee: nobody → emcminn
Iteration: --- → 88.1 - Feb 22 - Mar 7
Priority: -- → P1
Pushed by emcminn@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e3c58c9b1d75
Update theme screen CTA string r=fluent-reviewers,flod

https://hg.mozilla.org/mozilla-central/rev/e3c58c9b1d75

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

I have verified this enhancement and I can confirm the "Save Theme" button's label was changed into the "Done" one.
Verified using the latest Firefox Nightly (88.0a1 Build ID - 20210310093927) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.

Status: RESOLVED → VERIFIED
status-firefox88: fixed → verified
You need to log in before you can comment on or make changes to this bug.