1689348 - Remove non-syntactic scope support from JSExecutionContext

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Ted Campbell [:tcampbell]]

(Technically this code is in dom/base, but SpiderMonkey is more interested in the change)

The last remaining use of JSExecutionContext::SetScopeChain is in the nsPAPI plugin code which is slated for removal. Once this is done, we can remove support for non-syntactic script compilation which is being deprecated in spidermonkey.

Note that ScriptPreloader/FrameScripts continue to use non-syntactic envs, but use different loader code (and will probably be changed as well).

Note that inline event handler script still uses non-syntactic envs in future, but only with CompileFunction, while it is only global-scripts that we are deprecating.

Comment 1

[Jan de Mooij [:jandem]]

Just in case you missed it, JSExecutionContext::SetScopeChain is now unused and could be removed. Might be nice to do soonish before it finds new uses.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1689348 - Remove unused JSExecutionContext::SetScopeChain code. r?smaug!,nbp!

The last use of this method was the NSPAPI plugin code which has now been
removed. These non-syntactic exotic environments were used for non-standard
situations and suffered numerous performance and correctness issues so are
deprecated in general.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f021db40245
Remove unused JSExecutionContext::SetScopeChain code. r=smaug,nbp

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2f021db40245