Closed Bug 1689359 Opened 4 years ago Closed 4 years ago

Enable non-native theme on Linux Nightly.

Categories

(Core :: Widget: Gtk, task, P3)

Unspecified
Linux
task

Tracking

()

RESOLVED FIXED
87 Branch
Fission Milestone M7
Tracking Status
firefox87 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

No description provided.

Once all the remaining patches for test tweaks / fixes have landed, this
patch should be green on try. Couple test annotation changes:

  • clip-003.html fails the same way it fails on mac (odd, but couldn't
    repro...). I'll try to dig a bit more before calling it a day.

  • radiobutton-min-size starts behaving like every other platform.

  • Event-dispatch-redispatch and baseline-alignment-and-overflow start
    passing.

  • Couple minor fuzzy annotations (one was backwards, the other was
    missing).

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Severity: -- → N/A
Type: defect → task
Fission Milestone: --- → M7
OS: Unspecified → Linux
Priority: -- → P3
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d9e5a018312e Enable non-native-theme on Linux Nightly by default. r=spohl
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/31841a09424b scrolling-attr-1 needs the same threshold as scrolling-attr-2.
Regressions: 1689854
Regressions: 1689855
Regressions: 1689885
Regressions: 1689871
Regressions: 1689931
Depends on: 1690043

== Change summary for alert #28590 (as of Tue, 02 Feb 2021 13:19:39 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
22% perf_reftest_singletons scrollbar-styles-1.html linux64-shippable e10s stylo 410.62 -> 318.80
22% perf_reftest_singletons scrollbar-styles-1.html linux64-shippable-qr e10s stylo webrender 435.28 -> 339.12
22% cpstartup content-process-startup linux64-shippable-qr e10s stylo webrender-sw 129.08 -> 100.67
22% cpstartup content-process-startup linux64-shippable e10s stylo 128.83 -> 101.00
20% cpstartup content-process-startup linux64-shippable-qr e10s stylo webrender-sw 128.92 -> 102.83
20% cpstartup content-process-startup linux64-shippable-qr e10s stylo webrender 137.08 -> 109.75

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28590

Regressions: 1690494

== Change summary for alert #28600 (as of Wed, 03 Feb 2021 10:46:38 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
3% Base Content Heap Unclassified linux1804-64-shippable 3,650,017.33 -> 3,533,419.00
3% Base Content Heap Unclassified linux1804-64-shippable-qr 3,694,241.50 -> 3,577,851.33
3% Base Content Heap Unclassified linux1804-64-shippable-qr 3,693,031.00 -> 3,577,092.00

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28600

This again broke scrollbar arrows on Linux Manjaro for me.

History:

[rdk@on ~]$ mozregression --good  2021-01-28 -p /media/on/doc/tmplc9zis4t.mozrunner/ --pref security.sandbox.content.level:0 ^C
...

12:35.66 INFO: Downloading build from: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bdhjyENSSyixx_ft42Ewfw/runs/0/artifacts/public%2Fbuild%2Ftarget.tar.bz2
===== Downloaded 100% =====
13:24.27 INFO: Running autoland build built on 2021-02-03 11:59:17.781000, revision d6481478
13:37.20 INFO: Launching /tmp/tmp_ehuocfz/firefox/firefox
13:37.20 INFO: Application command: /tmp/tmp_ehuocfz/firefox/firefox --allow-downgrade -profile /tmp/tmp4nmg7yyo
13:37.21 INFO: application_buildid: 20210130161107
13:37.21 INFO: application_changeset: d6481478a8e01366fb3af2e0788aa6666429d5f1
13:37.21 INFO: application_name: Firefox
13:37.21 INFO: application_repository: https://hg.mozilla.org/integration/autoland
13:37.21 INFO: application_version: 87.0a1
Was this integration build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): good
13:46.72 INFO: Narrowed integration regression window from [a3231eeb, d9e5a018] (3 builds) to [d6481478, d9e5a018] (2 builds) (~1 steps left)
13:46.73 INFO: No more integration revisions, bisection finished.
13:46.73 INFO: Last good revision: d6481478a8e01366fb3af2e0788aa6666429d5f1
13:46.73 INFO: First bad revision: d9e5a018312eccf63acbda32759d90e2f92175d7
13:46.73 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d6481478a8e01366fb3af2e0788aa6666429d5f1&tochange=d9e5a018312eccf63acbda32759d90e2f92175d7

It's kind of expected, see bug 1676057. I guess we could add a pref to allow using scrollbar buttons on GTK with windows-looking scrollbars. Please file a bug and ni? me and I can look into it.

Regressions: 1690812
See Also: → 1689826
Regressions: 1691428
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: