Closed Bug 1689362 Opened 2 years ago Closed 6 months ago

Scroll tabs/Open a new tab/list all tabs toolbar buttons are not keyboard accessible.


(Firefox :: Tabbed Browser, defect, P5)






(Reporter: yzen, Unassigned)


(Blocks 1 open bug)


(Keywords: access, Whiteboard: [proton-tabs-bar][access-s3])

Not really Proton specific but perhaps can be addressed as part of this work. Right now these 3 buttons are not keyboard accessible. Keyboard focus switches from tabs in the tab bar straight into the navigation toolbar.

Whiteboard: [proton-tabs-bar] → [proton-tabs-bar][access-s2]

I'm marking as a P5 since it's not blocking Proton, we'll review priority as we get closer to Proton ship date and have capacity to address it.

Priority: -- → P5
Points: --- → 5
Component: Theme → Tabbed Browser
Severity: -- → S4

Jamie, do you recall if this is intentional in your work around keyboard focus in bug 1418973 and friends?

Blocks: 1418973
No longer blocks: proton-tabs-bar
Flags: needinfo?(jteh)

I intentionally didn't deal with this then, but that doesn't necessarily mean these shouldn't be keyboard accessible. The challenge is how to make them keyboard accessible. My aim with the toolbar work was to keep tab stops to a minimum so users can efficiently get to where they want to go. On one hand, a mouse user can access them, so a keyboard user should be able to access them. On the other hand, these buttons don't seem like they'd be used often by keyboard users, so it's hard to justify them consuming a tab stop and making the experience less efficient for other, far more common usage. Ideally, I think we'd somehow have it such that you right arrow to these buttons after tabbing to the tab strip, but I don't see how we can possibly implement this; the tab strip is a completely separate widget and it feels wrong to couple it with the toolbar code.

Flags: needinfo?(jteh)

Eitan, asking you as the person who triaged this. Given comment 3, do you think it's reasonable to downgrade this to an access-s3? Yes, the buttons are not keyboard accessible, but there are other, more efficient ways to access the same functionality with the keyboard (scrolling the tab strip with the arrow keys, searching tabs with the location bar, creating a new tab with control+t, etc.).

Flags: needinfo?(eitan)

Yeah, I think something I overlooked in my triage was the fact that this isn't a new issue. s3 makes sense.

Flags: needinfo?(eitan)
Whiteboard: [proton-tabs-bar][access-s2] → [proton-tabs-bar][access-s3]

The severity field for this bug is set to S4. However, the accessibility severity is higher, [access-s3].
:dao, could you consider increasing the severity?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dao+bmo)

The scroll buttons are still not accessible AFAICT, but the other buttons are, and all the tabs are accessible and they scroll the tabstrip, so I think we can mark this fixed? Feel free to reopen if you think I'm missing something. bug 1774742 let the tabstrip toobar change ride the trains.

Closed: 6 months ago
Depends on: 1774742
Flags: needinfo?(dao+bmo)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.