1689366 - Simplify Bookmarking subview

Status: VERIFIED FIXED

(Firefox :: Menus, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

This is something that can ship pre-Proton, so it can happen directly on PanelUI-bookmarks here: https://searchfox.org/mozilla-central/rev/0dfbe5a699cc6c73cf8c14d1aa10ba10ef3ec8fa/browser/base/content/browser.xhtml#1039-1072

The new Bookmarks subview structure should be:

Bookmarks  <header>
<separator>
Bookmark Current Tab
Search Bookmarks
Show Bookmarks Toolbar
<separator>
Recent Bookmarks <subheader>
<list of recent bookmarks>
View All Bookmarks

What we need to do:

1. Remove the Bookmarking Tools item and subview
2. Move the "View Bookmarks Toolbar" item into the Bookmarks subview
3. Replace the string for "View Bookmarks Toolbar" so that it's "Show Bookmarks Toolbar" and "Hide Bookmarks Toolbar"
4. Convert the "Show All Bookmarks" footer into a normal item below the list of recently bookmarked items
5. Replace the string in this menu for "Bookmark This Page" with "Bookmark Current Tab"
6. Replace the string for "Recently Bookmarked" to "Recent Bookmarks"
7. Replace the string in this menu for "Show All Bookmarks" with "View All Bookmarks"

One thing we need to figure out with UX is whether or not we're going to change the limit on how many Recent Bookmarks to show. We also need to figure out if there's a separator between that list and the "View All Bookmarks" item, or some other kind of delineation.

Remember when updating strings to ensure that they're not re-used elsewhere - if so, double-check that the propagated change is acceptable with UX, or create a new string just for the menu.

Also remember that if you're updating a string, you still have to update the ID of it so that our localizers know to re-translate.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

(Naturally, any tests that rely on the old structure or old behaviours will need to be modified as well)

Comment 2

[Emma Malysz]

Attachment: Bug 1689366, simplify bookmark panel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd749c4aeba6
simplify bookmark panel r=fluent-reviewers,mconley,flod

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/fd749c4aeba6

Comment 5

[Raluca Popovici, Desktop QA]

Verified - Fixed in latest Fx 87.0, Fx 88.0, Fx 89.0b10 and Nightly 90.0a1 using Windows 10, Ubuntu 20.04 and MacOS 11.