Closed Bug 1689378 Opened 3 years ago Closed 3 years ago

Simplify Recently Closed Tabs and Recently Closed Windows subviews

Categories

(Firefox :: Menus, defect, P3)

defect

Tracking

()

VERIFIED FIXED
87 Branch
Tracking Status
firefox87 --- verified

People

(Reporter: mconley, Assigned: emmamalysz)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-hamburger-menu])

Attachments

(1 file)

This is something that can ship pre-Proton, so it can happen immediately, and doesn't need to be behind a pref.

The Recently Closed Tabs and Recently Closed Windows subviews are dynamically generated. They have their "showing" event handlers set up here:

https://searchfox.org/mozilla-central/rev/0dfbe5a699cc6c73cf8c14d1aa10ba10ef3ec8fa/browser/components/customizableui/CustomizableWidgets.jsm#125-133

and the actual work of filling them with items is here:

https://searchfox.org/mozilla-central/rev/0dfbe5a699cc6c73cf8c14d1aa10ba10ef3ec8fa/browser/components/customizableui/CustomizableWidgets.jsm#158-194

There are some utilities and abstractions in browser/components/sessionstore/RecentlyClosedTabsAndWindowsMenuUtils.jsm that will likely need some slight modification.

The structures (I'm combining them here since they're so similar, but they remain two separate submenus) should be:

Recently Closed Tabs/Windows <header>
<separator>
<list of recently closed tabs/windows>
<separator>
Reopen All Tabs/Windows

What we need to do:

  1. Remove the keyboard shortcut indicator on the first item in both subviews. This can be done by removing these lines, and then I think we can also then get rid of this
  2. Turn the "Restore All Tabs" and "Restore All Windows" footer into a normal toolbarbutton subview item
  3. Rename "Restore All Tabs" to "Reopen All Tabs"
  4. Rename "Restore All Windows" to "Reopen All Windows"

One thing we need to figure out with UX is whether or not we're going to change the limit on how many recently closed tabs / windows to show - that list can get quite long. Do we limit the number to show, or do we make the list a fixed maximum height with a scrollbar? Or something else entirely?

Remember when updating strings to ensure that they're not re-used elsewhere - if so, double-check that the propagated change is acceptable with UX, or create a new string just for the menu.

Also remember that if you're updating a string, you still have to update the ID of it so that our localizers know to re-translate.

(Naturally, any tests that rely on the old structure or old behaviours will need to be modified as well)

Severity: -- → S3
Type: task → defect
Priority: -- → P3
Assignee: nobody → emalysz
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61892c5fe604
update recently closed windows and tabs panels r=mconley,fluent-reviewers,flod
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #0)

  1. Remove the keyboard shortcut indicator on the first item in both subviews.

I believe this was the only place where we exposed the Undo Close Window shortcut? (Undo Close Tab is exposed in the tab menu, which we currently only show when overflowing, and we might want to replace this item with the subview in the future.) Was this known context for this change? I'm a bit puzzled as to how this removal, while it is technically a simplification, can be seen as a net win.

Flags: needinfo?(mconley)
Regressions: 1692522

Checking back with Meridel and amylee. Let's track this in bug 1692522.

Flags: needinfo?(mconley)
See Also: → 1693098

Confirm that keyboard shortcut indicator appears again in the latest Nightly 89.0a1(See the fixed bug 1692522).
Verified - Fixed in latest Nightly 89.0a1 (2021-04-19), Fx 87.0 and Fx 88.0, using Windows 10x64 and Mac 11.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: