1689502 - Make all Normandy test decorators three layer decorators, for consistency

Status: RESOLVED FIXED

(Firefox :: Normandy Client, task, P3)

Description

[Michael Cooper [:mythmon]]

In Phabricator review D102981 Gijs wrote: https://phabricator.services.mozilla.com/D102981#3343699

Also, would it be worth having a follow-up to settle on a pattern for the test task decoration? Reading something like:

decorate_task(
  PreferenceExperiments.withMockExperiments([
    factories.preferenceStudyFactory({
      enrollmentId: "test-enrollment-id",
    }),
  ]),
  AddonStudies.withStudies([
    factories.addonStudyFactory({ slug: "test-study" }),
  ]),
  PreferenceRollouts.withTestMock(),
  AddonRollouts.withTestMock,

is a little bit odd (ie some things are function calls (that return functions) and others are direct function references, for no clear reason).

This bug covers changing all decorators used in Normandy tests (such as AddonRollouts.withTestMock to use the "decorator maker" pattern, in which instead of being a decorator directly, they are functions which take (possibly zero) arguments, and then return a decorator. This makes the decorators more consistent, and makes it easier to add arguments to decorators in the future should it be needed.

Comment 1

[Michael Cooper [:mythmon]]

Attachment: Bug 1689502 - Make all Normandy test decorators three layer decorators, for consistency r=gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38ba1cfafe7a
Make all Normandy test decorators three layer decorators, for consistency r=Gijs

Comment 3

[Alexandru Michis [:malexandru]]

Backed out 3 changesets (bug 1693581, bug 1689502, bug 1696058) for causing bc failures in browser_Troubleshoot.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/1869ce68e5daed9f9802be0764f0eee5b850202d
Push with failures, failure log,

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3510c9a66246
Make all Normandy test decorators three layer decorators, for consistency r=Gijs

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3510c9a66246