1689516 - Remove AudioNotification{Sender, Receiver}

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, task, P2)

Description

[Matthew Gregan [:kinetik]]

This bug is a follow up to the discussion in bug 1507182 comment 6.

AudioNotification{Sender, Receiver} was introduced in bug 1361336 as a Windows-only addition to work around tighter sandbox restrictions breaking libcubeb's visibility of default device change events in content processes.

With the shipping of AudioIPC on Windows (bug 1432303), libcubeb is no longer constrained by the content sandbox and AudioNotification{Sender, Receiver} becomes obsolete.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Bug 1689516 - Remove AudioNotification{Sender, Receiver}. r?padenot

Comment 2

[Matthew Gregan [:kinetik]]

Note: once this patch lands, it will effectively regress bug 1361336 in the situation where media.cubeb.sandbox is set to false (non-default) without also disabling or lowering the content sandbox. As this is an unsupported configuration for testing only purposes and the pref will eventually be removed, it doesn't seem worth keeping the AudioNotification code to handle this case.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7dafa45984f1
Remove AudioNotification{Sender, Receiver}.  r=chunmin

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7dafa45984f1