Closed Bug 1689524 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 27382 - Don't require perspective to be a layout shift root.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox87 fixed)

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27382 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27382
Details from upstream follow.

b'Chris Harrelson <chrishtr@chromium.org>' wrote:

Don't require perspective to be a layout shift root.

If an element is a layout shift root, then it needs to be a paint
offset root also, or else the way we compute accumulated transform
offsets will fail when trying to cross the layout shift root.

Unfortunately the logic for the two look quite different, we should
unify in a subsequent patch.

Perspective was added as a layout shift root in a previous patch,
but there was I think not a particular reason to do so. If paint
offsets can accumulate across perspective, so can layout shift.

Fixed: 1157797

Change-Id: Ia6e123bbc9219ae03235af51a171a084ab8078c8

Reviewed-on: https://chromium-review.googlesource.com/2657540
WPT-Export-Revision: 22a7f09a867b16e39e90daeb2de7557634243514

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/layout-instability/transform-above-perspective-dynamic.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
addition of transform above perspective: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/layout-instability/transform-above-perspective-dynamic.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bcd707b3ff63 [wpt PR 27382] - Don't require perspective to be a layout shift root., a=testonly

https://hg.mozilla.org/mozilla-central/rev/bcd707b3ff63

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.