Closed Bug 1689648 Opened 4 years ago Closed 4 years ago

bugprone-assert-side-effect message text changed in clang-13

Categories

(Developer Infrastructure :: Source Code Analysis, defect, P4)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: away, Unassigned)

References

(Blocks 1 open bug)

Details

We won't need this for at least six months but the patch is:

diff --git a/tools/clang-tidy/test/bugprone-assert-side-effect.json b/tools/clang-tidy/test/bugprone-assert-side-effect.json
--- a/tools/clang-tidy/test/bugprone-assert-side-effect.json
+++ b/tools/clang-tidy/test/bugprone-assert-side-effect.json
@@ -1,1 +1,1 @@
-[["warning", "found assert() with side effect", "bugprone-assert-side-effect"], {"reliability": "high"}]
\ No newline at end of file
+[["warning", "side effect in assert() condition discarded in release builds", "bugprone-assert-side-effect"], {"reliability": "high"}]
Priority: -- → P4
Assignee: away → nobody

Already fixed.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.