Change newtab wordmark color from #363959 to #20123A if newnewtabExperience is enabled
Categories
(Firefox :: New Tab Page, task, P1)
Tracking
()
People
(Reporter: prathiksha, Assigned: prathiksha)
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by prathikshaprasadsuman@gmail.com: https://hg.mozilla.org/integration/autoland/rev/9774bda3ee65 Change newtab wordmark color from #363959 to #20123A if logowordmark.alwaysVisible is set to true. r=ewright
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 4•3 years ago
|
||
Comment on attachment 9200410 [details]
Bug 1689996 - Change newtab wordmark color from #363959 to #20123A if logowordmark.alwaysVisible is set to true.
Beta/Release Uplift Approval Request
- User impact if declined: Firefox wordmark color will be incorrect in an experiment
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small style change hidden behind a pref for experiments
- String changes made/needed: None
|
||
Comment 5•3 years ago
|
||
Comment on attachment 9200410 [details]
Bug 1689996 - Change newtab wordmark color from #363959 to #20123A if logowordmark.alwaysVisible is set to true.
Low risk, approved for 86 beta 6, thanks.
|
||
Comment 6•3 years ago
|
||
This has conflicts. Please attach a rebased patch for Beta uplift.
|
|
Assignee | |
Comment 7•3 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
This has conflicts. Please attach a rebased patch for Beta uplift.
Hm, I don't see any conflicts when I pull the patch on my beta build. For now, I think it's ok if this is not uplifted to beta. Thanks Ryan!
|
|
||
Comment 8•3 years ago
|
||
| bugherder uplift | ||
Grafts cleanly now - I'm guessing bug 1688683 was the missing dep.
https://hg.mozilla.org/releases/mozilla-beta/rev/3a9a5c055a64
|
||
Comment 9•3 years ago
|
||
I have verified that this issue is no longer reproducible with the latest Firefox Beta (86.0b6 Build ID - 20210204185843) and the latest Firefox Nightly (87.0a1 Build ID - 20210204192309) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64. Now, I can confirm that the wordmark color (newtab-wordmark-color) is #20123A.
Description
•