Closed Bug 1690025 Opened 2 years ago Closed 2 years ago

Modernize and clean up DirectoryLock

Categories

(Core :: Storage: Quota Manager, task, P2)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox87 --- wontfix
firefox90 --- fixed

People

(Reporter: janv, Assigned: janv)

References

(Blocks 1 open bug)

Details

Attachments

(7 files)

The public DirectoryLock class will be split into a hierarchy of public classes as part of this cleanup. The problem is that DirectoryLock currently contains methods which are meaningful only on specific lock types.

Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/144da6ae3f80
Replace already_AddRefed<DirectoryLock> with RefPtr<DirectoryLock>; r=dom-workers-and-storage-reviewers,sg

This is especially about changing CreateDirectoryLockForEviction to not create
a lock directly using MakeRefPtr.

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4d461cbfc35
Make all directory lock creating methods use a common internal method; r=dom-workers-and-storage-reviewers,sg
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2684aad61a6b
Create directory locks using factories defined on DirectoryLockImpl class; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/d2b39aebfad2
Move DirectoryLock class to a separate file; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/5d5e90d31294
Move DirectoryLockImpl class to separate files; r=dom-storage-reviewers,sg
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10f2c8a01847
Create directory locks using factories defined on DirectoryLockImpl class; r=dom-storage-reviewers,sg
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b6e9849ba80
Move DirectoryLock class to a separate file; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/cac1fc088ea5
Move DirectoryLockImpl class to separate files; r=dom-storage-reviewers,sg
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b3da6e34456
Split public DirectoryLock class into a hierarchy of public classes; r=dom-storage-reviewers,sg
Flags: needinfo?(jvarga)
Keywords: leave-open
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29553ddc66ad
Move and rename DirectoryLock::Specialize to UniversalDirectoryLock::SpecializeForClient; r=dom-storage-reviewers,asuth
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: 87 Branch → 90 Branch
You need to log in before you can comment on or make changes to this bug.