Closed
Bug 1690025
Opened 4 years ago
Closed 4 years ago
Modernize and clean up DirectoryLock
Categories
(Core :: Storage: Quota Manager, task, P2)
Core
Storage: Quota Manager
Tracking
()
RESOLVED
FIXED
90 Branch
People
(Reporter: janv, Assigned: janv)
References
(Blocks 1 open bug)
Details
Attachments
(7 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
The public DirectoryLock
class will be split into a hierarchy of public classes as part of this cleanup. The problem is that DirectoryLock
currently contains methods which are meaningful only on specific lock types.
Assignee | ||
Comment 1•4 years ago
|
||
Depends on D103279
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/144da6ae3f80
Replace already_AddRefed<DirectoryLock> with RefPtr<DirectoryLock>; r=dom-workers-and-storage-reviewers,sg
Assignee | ||
Comment 3•4 years ago
|
||
This is especially about changing CreateDirectoryLockForEviction to not create
a lock directly using MakeRefPtr.
Comment 4•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4d461cbfc35
Make all directory lock creating methods use a common internal method; r=dom-workers-and-storage-reviewers,sg
Comment 6•4 years ago
|
||
bugherder |
Assignee | ||
Comment 7•4 years ago
|
||
Depends on D103886
Assignee | ||
Comment 8•4 years ago
|
||
Depends on D104147
Assignee | ||
Comment 9•4 years ago
|
||
Depends on D104154
Assignee | ||
Comment 10•4 years ago
|
||
Depends on D104163
Comment 11•4 years ago
|
||
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2684aad61a6b
Create directory locks using factories defined on DirectoryLockImpl class; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/d2b39aebfad2
Move DirectoryLock class to a separate file; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/5d5e90d31294
Move DirectoryLockImpl class to separate files; r=dom-storage-reviewers,sg
Comment 12•4 years ago
|
||
Backed out for causing failure on Client.h.
Backout link: https://hg.mozilla.org/integration/autoland/rev/d5136aca4276da67d1104a210016b80e700e36b4
Failure log: https://treeherder.mozilla.org/logviewer?job_id=329317493&repo=autoland&lineNumber=5339
Flags: needinfo?(jvarga)
Comment 13•4 years ago
|
||
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10f2c8a01847
Create directory locks using factories defined on DirectoryLockImpl class; r=dom-storage-reviewers,sg
Comment 14•4 years ago
|
||
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b6e9849ba80
Move DirectoryLock class to a separate file; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/cac1fc088ea5
Move DirectoryLockImpl class to separate files; r=dom-storage-reviewers,sg
Comment 15•4 years ago
|
||
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b3da6e34456
Split public DirectoryLock class into a hierarchy of public classes; r=dom-storage-reviewers,sg
Comment 16•4 years ago
|
||
bugherder |
Comment 17•4 years ago
|
||
bugherder |
Assignee | ||
Comment 18•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(jvarga)
Keywords: leave-open
Comment 19•4 years ago
|
||
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29553ddc66ad
Move and rename DirectoryLock::Specialize to UniversalDirectoryLock::SpecializeForClient; r=dom-storage-reviewers,asuth
Comment 20•4 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: 87 Branch → 90 Branch
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•