1690034 - Add more Rust OOM stuff (alloc::alloc::__alloc_error_handler::__rg_oom) to the irrelevant signature list

Status: RESOLVED FIXED

(Socorro :: Signature, task)

Description

[Andrew McCreight [:mccr8]]

As seen in bug 1689956, all Rust OOMs seem to be getting globbed into a single signature, which is bad.

I think alloc::alloc::__alloc_error_handler::__rg_oom should be added to the irrelevant signature list, but I should look over a few crashes and make sure that is enough.

Comment 1

[Andrew McCreight [:mccr8]]

Looks like it would be good for __rust_alloc_error_handler to be added, too. I'll put together a pull request.

Here are two different crashes that are showing up with the same signature:

bp-e17483cd-347e-46fb-ab61-fdc320210131
bp-68d7923e-1dbc-4346-824e-ebd0b0210201

Comment 2

[Andrew McCreight [:mccr8]]

It looks like Bug 1689956 is a concern about beta, so if those could get reprocessed I think that would be useful.

Comment 3

[Andrew McCreight [:mccr8]]

https://github.com/mozilla-services/socorro/pull/5670

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5670: "fix bug 1690034 - Add Rust OOM stuff to the irrelevant signature list." in 7ecebcd.

I noticed that _rust_alloc_error_handler (single underscore) shows up, too, so I'm going to add that in a follow-up PR.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5671: Bug 1690034: add _rust_alloc_error_handler to irrelevant list

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5671: "Bug 1690034: add _rust_alloc_error_handler to irrelevant list" in ae83c5c.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was deployed just now in bug #1690378.

I reprocessed 440 crash reports over the last 6 months.

Marking as FIXED.