Dark mode separator is too dark no contrast
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
People
(Reporter: webmaster, Unassigned)
Details
Attachments
(1 file)
|
29.82 KB,
image/png
|
Details |
2021-02-01_17-40.png
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:85.0) Gecko/20100101 Firefox/85.0
Steps to reproduce:
I'm on (vanilla) Ubuntu, using Dark mode.
Firefox adapts dark mode.
In the toolbar menu the separators are white. But separators in a folder are almost not visible.
Expected results:
Increase contrast
|
||
Comment 1•3 years ago
|
||
Reproduced on the latest Firefox Nightly 87.0a1 (2021-02-04), beta 86.0b6 and release 85.0 on Ubuntu 20.04.
Setting a component and updating the flags accordingly.
If you feel it's an incorrect one please feel free to change it to a more appropriate one.
This is not a recent regression as this could be reproduced all the way back to Firefox 69.0.
QA considers this to be an S4 severity.
|
||
Updated•3 years ago
|
|
|
||
Comment 2•3 years ago
|
||
I'm guessing this is fallout from bug 1665442. Gijs, what do you think we should do here?
|
||
Comment 3•3 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
I'm guessing this is fallout from bug 1665442. Gijs, what do you think we should do here?
I don't think so, this is a gtk theme issue ( see bug 1631554 and its other dupes). I am fairly confident given that it is specifically about menu separators, and the styling changes in bug 1665442 were specific to toolbar separators, which are different elements. In the screenshot, the toolbar separators are reasonably visible (as mentioned in comment #0).
|
Reporter | |
Comment 4•3 years ago
|
||
To clarify. In the toolbar it's visible enough, but in the dropdown of the toolbar it's next to invisible.
|
|
||
Comment 5•3 years ago
|
||
(In reply to Jan Willem Oostendorp from comment #4)
To clarify. In the toolbar it's visible enough, but in the dropdown of the toolbar it's next to invisible.
Yep. I suspect our GTK integration isn't providing us with the best colours there. Not sure why.
Description
•