Closed Bug 1690076 Opened 3 years ago Closed 3 years ago

Move PiP overrides from webcompat add-on into its own system addon

Categories

(Toolkit :: Video/Audio Controls, task, P3)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: mtigley, Assigned: popeoliv)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

This would make it easier for us to continue adding site-specific PiP fixes/features independent of the WebCompat addon. There's been a discussion about this in https://bugzilla.mozilla.org/show_bug.cgi?id=1670108#c9.

Blocks: videopip

We should be creating a separate directory to house the standalone Picture-in-Picture web extension. To get started:

  • Create a directory called pictureinpicture at browser/extensions/
  • Create a moz.build and manifest.json with the necessary information required for creating a web extension. See the WebCompat Addon for an example.

Next, we want to move the PiP overrides and experimental APIs initially created in https://phabricator.services.mozilla.com/D57375 to this folder. I think it's fine if we keep the initial folder structure for now.

Additional resources about developing web extensions in Firefox:

Assignee: nobody → popeoliv
Status: NEW → ASSIGNED
Attachment #9203614 - Attachment description: Bug 1690076 - added new dir pictureinpicture with proper files from webcompat extension to facilitate a migration from webcompat r=mtigley,mhowell → Bug 1690076 - Move Picture-in-Picture site overrides into its own Firefox Extension r=mtigley,mhowell
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46f5fcba78c3
Move Picture-in-Picture site overrides into its own Firefox Extension r=mtigley,mhowell,webcompat-reviewers,denschub,robwu
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: