1690105 - Implement RemoteSettings client in DoHConfig.jsm for provider and config data collections

Status: RESOLVED FIXED

(Firefox :: Security, enhancement, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

New collections were created in bug 1689089 and bug 1684826. DoHConfig.jsm needs to implement a Remote Settings client to fetch and sync records from these collections and serve them through the data access APIs.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1690105 - Implement RemoteSettings client in DoHConfig.jsm for provider and config data collections. r=dragana!

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1690105 - Add initial JSON dumps for doh-providers and doh-config collections. r=#necko!,Gijs!

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Try looks good except for needing to flag DoHTestUtils as a testing module in moz.build: https://treeherder.mozilla.org/jobs?repo=try&revision=ba11f652130893dc959870c69c622bc54027eaa0&selectedTaskRun=Pw-Z3PoHQNGnTPrGk8l0RA.0

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e61ccce8c00
Implement RemoteSettings client in DoHConfig.jsm for provider and config data collections. r=dragana,preferences-reviewers,Gijs
https://hg.mozilla.org/integration/autoland/rev/656fd67b37fb
Add initial JSON dumps for doh-providers and doh-config collections. r=Gijs,necko-reviewers,dragana

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_remoteSettings_rollout.js

backout: https://hg.mozilla.org/integration/autoland/rev/6adf3e04d40e2a9a1a69dc06fe101dc5a54ef615

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=656fd67b37fb349b596bc789fd7ae8f8baae389a

failure log: https://treeherder.mozilla.org/logviewer?job_id=341047735&repo=autoland&lineNumber=3588

[task 2021-05-28T10:08:11.980Z] 10:08:11 INFO - TEST-PASS | browser/components/doh/test/browser/browser_remoteSettings_rollout.js | TRR mode is 2 -
[task 2021-05-28T10:08:11.980Z] 10:08:11 INFO - Buffered messages finished
[task 2021-05-28T10:08:11.981Z] 10:08:11 INFO - TEST-UNEXPECTED-FAIL | browser/components/doh/test/browser/browser_remoteSettings_rollout.js | Found the expected heuristics event. - Got 3, expected 1
[task 2021-05-28T10:08:11.982Z] 10:08:11 INFO - Stack trace:
[task 2021-05-28T10:08:11.982Z] 10:08:11 INFO - chrome://mochikit/content/browser-test.js:test_is:1362
[task 2021-05-28T10:08:11.982Z] 10:08:11 INFO - chrome://mochitests/content/browser/browser/components/doh/test/browser/head.js:checkHeuristicsTelemetry:217
[task 2021-05-28T10:08:11.982Z] 10:08:11 INFO - TEST-PASS | browser/components/doh/test/browser/browser_remoteSettings_rollout.js | The event records the expected decision -

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Mmmm, there's no need to check telemetry here, we can just ensureTRRMode(2) for sanity and be done with it since the point is to check that the config was updated. (The extra telemetry is because of DoHController reset'ing when new config is available, and it's racy enough that I can't repro that locally and it's only failing on Windows 7 opt. I'm making the test wait for a config flush now)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2d171d79b6d
Implement RemoteSettings client in DoHConfig.jsm for provider and config data collections. r=dragana,preferences-reviewers,Gijs
https://hg.mozilla.org/integration/autoland/rev/f6fbf6487e6d
Add initial JSON dumps for doh-providers and doh-config collections. r=Gijs,necko-reviewers,dragana

Comment 8

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1690105) for causing bc failures in browser_rollback.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/88faed0b4221c1d14f672b7d74f330ad3ad80c74
Push with failures, failure log.

Comment 9

[(inactive) Nihanth Subramanya [:nhnt11]]

That's really strange. The patches that landed in comment 7 removed the line that caused the failure in the link. Can be confirmed by comparing browser_remoteSettings_rollout.js between the two revisions:

1. Revision in the push with failures linked in comment 8: https://hg.mozilla.org/integration/autoland/file/defb5b4a43504df3b53045fa378f01df95e27fc8/browser/components/doh/test/browser/browser_remoteSettings_rollout.js

2. Revision that landed in comment 7: https://hg.mozilla.org/integration/autoland/diff/c2d171d79b6def395aa446d0df061865d0cd2ffc/browser/components/doh/test/browser/browser_remoteSettings_rollout.js

Note that in [1] there is line 30: await checkHeuristicsTelemetry("enable_doh", "startup");

This was removed in [2] which landed in comment 7.

Comment 10

[Alexandru Michis [:malexandru]]

My bad, I linked a failure that appeared on the first landing, the new one is only on browser_rollback.js
https://treeherder.mozilla.org/logviewer?job_id=341091446&repo=autoland&lineNumber=3601

Comment 11

[(inactive) Nihanth Subramanya [:nhnt11]]

Try looks good after disabling the remote settings tests on win32: https://treeherder.mozilla.org/jobs?repo=try&revision=b9dd093e9ab9f44319b450d10b4f52cb4e5b787d&selectedTaskRun=bqvcHTXrTSeOkKYi43oElA.0

Something in these tests is creating some interference with the subsequent ones on win32 opt (apparently not on any other platforms, even with TV).

Gonna try to land again.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/131ca69d56a2
Implement RemoteSettings client in DoHConfig.jsm for provider and config data collections. r=dragana,preferences-reviewers,Gijs
https://hg.mozilla.org/integration/autoland/rev/f08d206ea0f3
Add initial JSON dumps for doh-providers and doh-config collections. r=Gijs,necko-reviewers,dragana

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/131ca69d56a2
https://hg.mozilla.org/mozilla-central/rev/f08d206ea0f3