Closed Bug 1690266 Opened 2 years ago Closed 2 years ago

Wrong Tooltip for ImgDecoder on about:profiling page

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Version:
Firefox 87
Type:
defect

Tracking

(firefox-esr78 unaffected, firefox85 unaffected, firefox86 wontfix, firefox87 fixed)

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox85 --- unaffected
firefox86 --- wontfix
firefox87 --- fixed

People

(Reporter: joradan0, Assigned: julienw)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1690266 - Fix the l10n-id for the thread ImgDecoder in about:profiling r=gregtatum!
48 bytes, text/x-phabricator-request
Details | Review

When i open about:profiling in Firefox 87.0a1 (2021-02-02) (64-bit) om Linux Mint and point at the "ImgDecoder" preference, I see the tooltip "DNS resolution happens on this thread".
I expected to see "Image decoding threads".

Ah thanks, we made a mistake when we localized this part indeed.
We clearly see in [1] that the l10n id is incorrect.
It's a good thing that we have an existing l10n id for just this: [2].

I'll gladly review a quick patch for this, otherwise I can have a look later in the week or next week.

[1] https://searchfox.org/mozilla-central/rev/4e290edc65023e16f5fe7d12f84d3b629433c7ab/devtools/client/performance-new/components/Settings.js#157
[2] https://hg.mozilla.org/mozilla-central/rev/589ce4061beb7a47ff59f6249eed07314d08e653#l1.99

Severity: -- → S4
Priority: -- → P2
Regressed by: 1599774
Has Regression Range: --- → yes

Set release status flags based on info from the regressing bug 1599774

status-firefox85: --- → unaffected
status-firefox86: --- → affected
status-firefox87: --- → affected
status-firefox-esr78: --- → unaffected
Assignee: nobody → felash
Pushed by jwajsberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d227aa6abcf
Fix the l10n-id for the thread ImgDecoder in about:profiling r=gregtatum DONTBUILD

https://hg.mozilla.org/mozilla-central/rev/5d227aa6abcf

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox87: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
QA Whiteboard: [qa-87b-p2]
You need to log in before you can comment on or make changes to this bug.