1690387 - Attempting to import a secret key with no account identities set up causes: TypeError: can't access property "email", gIdentity is null

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Lasana Murray]

This happens when I click the "Import Secret Key(s) from File" menu entry. The error is thrown here:

https://searchfox.org/comm-central/source/mail/extensions/openpgp/content/ui/keyWizard.js#185

A consequence of this error is that the sub-dialog shows the "wizardStart" section instead of the "wizardImportKey" section.

Comment 1

[Lasana Murray]

So my question now is, should we bother to fix this or should the key manager be disabled if there are no configured identities?

Comment 2

[Magnus Melin [:mkmelin]]

The key manager should be enabled regardless of whether we have identities. People may want to use that so that they can import keys to configure identities to use them. And also handling of other people's keys.

Comment 3

[Alessandro Castellani [:aleca]]

I'm not sure about this as I'm not acquainted with the technical requirements of an OpenPGP secret key.
Does the secret key need to be attached/associated to an identity in order to work?
Do we even allow that? (I don't think we currently do)

I think we should fix it if it's an expected behavior or something that other software can do.
Maybe Kai has more insights on this.

Comment 4

[Magnus Melin [:mkmelin]]

Keys are just keys. They can be associated to an identity or not. The key can be used to decrypt even if it's not associated with an identity. This could be fairly common: e.g. an old key you have, and you're decrypting old mails - but the key is not associated to anything.

Comment 5

[Lasana Murray]

Attachment: bug1690387.patch

This changes the window title update to only happen if the menu has a selected item.

Comment 6

[Alessandro Castellani [:aleca]]

Comment on attachment 9201509 [details] [diff] [review]
bug1690387.patch

Review of attachment 9201509 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, this does it, thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3867cee7853f
Do not update identity email in key generation dialog if no identity set. r=aleca

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9201509 [details] [diff] [review]
bug1690387.patch

[Approval Request Comment]
User impact if declined: user confusion is importing keys under certain conditions.
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low risk

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9201509 [details] [diff] [review]
bug1690387.patch

[Triage Comment]
Approved for esr78

Comment 10

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-esr78/rev/7be337a5125a66830342d56a3196b9e6cc1f1030

= 78.8.1