Closed Bug 1690409 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27447 - Make <dialog> hide open <popup> elements

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27447 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27447
Details from upstream follow.

b'Mason Freed <masonfreed@chromium.org>' wrote:

Make <dialog> hide open <popup> elements

Per the explainer [1]:

"A dialog will dismiss a popup when shown but the
converse isn't true."

This CL implements this behavior, plus a test to verify.

[1] https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/Popup/explainer.md#alternate-solutions-considered

Bug: 1168738
Change-Id: I68fc231169a258bf4c167fd5b1fef4a1961bb533
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/2660195
WPT-Export-Revision: 20de526027ffa4628ece72708fb81f7fb9d182fa

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
FAIL: 3

Chrome

OK : 1
FAIL: 3

Safari

OK : 1
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/interactive-elements/the-popup-element/popup-stacking.tentative.html
popup stacking behavior: FAIL (Chrome: FAIL, Safari: FAIL)
popups should be closed by dialogs: FAIL (Chrome: FAIL, Safari: FAIL)
dialogs should not be closed by popups: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d9f5de43285
[wpt PR 27447] - Make <dialog> hide open <popup> elements, a=testonly
https://hg.mozilla.org/integration/autoland/rev/1a79c9f60530
[wpt PR 27447] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3d9f5de43285
https://hg.mozilla.org/mozilla-central/rev/1a79c9f60530

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.