1690430 - AsyncPanZoomController::ApplyAsyncTestAttributes does not clamp scroll

Status: VERIFIED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Sawyer Bergeron]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

1. Write test that applies a negative scroll to a scrollable region

Actual results:

Content freely scrolls past bounds of track

Expected results:

Content should be clamped, with any end-of-track effect (such as overscroll) applied

Comment 1

[Sawyer Bergeron]

Attachment: Bug 1690430 - Clamp scroll offset during ApplyAsyncTestAttributes. r=tnikkel

Comment 2

[Botond Ballo [:botond]]

I posted a patch in a dependent bug 1695385 to fix the tests which this change would regress (there were only three). With that in place, I expect this change should not require any further test changes.

Comment 3

[Botond Ballo [:botond]]

Stealing as this is blocking bug 1697681 (via bug 1697712 and bug 1686146).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91085d3da293
Clamp scroll offset during ApplyAsyncTestAttributes. r=tnikkel

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/91085d3da293

Comment 6

[Andrei Purice]

Verified fixed in beta 89.0b2 (20210420191345) and Nightly 90.0a1 (2021-04-20) (20210420213949) on MacOS 11.2.3 and M1 MacOS Big Sur 11.0.1.