1690447 - Update MultiStage onboarding template to display PinToTaskbar image

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Existing onboarding template supports displaying video with image as a fallback option. To display an image we needs custom styles to override video styling ( has fade container used for previously implemented privacy video).

Patch updates multistage onboarding template to handle image type with source set in JSON irrespective of container width and height

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1690447 - Update MultiStage onboarding template to display PinToTaskbar image

Comment 2

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:

This fix is required to run 'show user how to pin' onboarding experiment as logged in JIRA https://jira.mozilla.com/browse/UJET-72

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81867ce5c433
Update MultiStage onboarding template to display PinToTaskbar image r=emcminn

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/81867ce5c433

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Please request an uplift to beta if this is needed for our 86 release, thanks!

Comment 6

[Punam Dahiya [:pdahiya]]

Comment on attachment 9200816 [details]
Bug 1690447 - Update MultiStage onboarding template to display PinToTaskbar image

Beta/Release Uplift Approval Request

• User impact if declined: Patch is required to run manual pinning onboarding experiment in 86 https://jira.mozilla.com/browse/UJET-72
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See Test Plan in https://phabricator.services.mozilla.com/D103862
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is only needed for experiment and will not be visible in default onboarding
• String changes made/needed: None

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the "Pin Firefox to your taskbar" slide is successfully displayed on the "about:welcome" page and it contains the following elements:

• The Firefox logo is displayed in the top part of the page.
• The "Pin Firefox to your taskbar" title is displayed under the logo.
• The "Fast, safe, and private browsing every time you use the web." description is displayed under the title.
• The "Pin to Taskbar" animation is displayed under the description.
• The "Start Setup" primary button is displayed under the animation.
• The "Open the menu for the Firefox icon in the taskbar." subtitle is displayed under the button.
• Two grey lines are displayed under the subtitle.

Verified using the latest Firefox Nightly (87.0a1 Build ID - 20210205093454) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9200816 [details]
Bug 1690447 - Update MultiStage onboarding template to display PinToTaskbar image

Approved for 86 beta 7, thanks.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/2480f99d3bda

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the "Pin Firefox to your taskbar" slide is successfully displayed on the "about:welcome" page and it contains the following elements:

• The Firefox logo is displayed in the top part of the page.
• The "Pin Firefox to your taskbar" title is displayed under the logo.
• The "Fast, safe, and private browsing every time you use the web." description is displayed under the title.
• The "Pin to Taskbar" animation is displayed under the description.
• The "Start Setup" primary button is displayed under the animation.
• The "Open the menu for the Firefox icon in the taskbar." subtitle is displayed under the button.
• Two grey lines are displayed under the subtitle.

Verified using the latest Firefox Beta (86.0b7 Build ID - 20210207185447) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.