Closed Bug 1690461 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 27453 - Revert "Store bit for paint offset translation was present before reattach"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox87 fixed)

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27453 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27453
Details from upstream follow.

b'Findit <findit-for-me@appspot.gserviceaccount.com>' wrote:

Revert "Store bit for paint offset translation was present before reattach"

This reverts commit 756c3e7736d91560f2ff85914be31c30316c13fa.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 849919 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc1NmMzZTc3MzZkOTE1NjBmMmZmODU5MTRiZTMxYzMwMzE2YzEzZmEM

Sample Failed Build: https://ci.chromium.org/b/8856342357767509280

Sample Failed Step: xr_browser_tests

Original change's description:

Store bit for paint offset translation was present before reattach

This allows PaintPropertyTreeBuilder to skip any paint offset
translation for a reattached node in the subsequent pre-paint, because
if the previous frame encountered a paint offset translation, the
paint offset of the object does not aggregate across it. Therefore
the old and new paint offsets both skip it and the new one should
also be skipped.

The bit helps to distinguish between the case of a paint offset
translation re-allocated due to reattach and deletion of a LayoutObject,
vs a style change that caused a new paint offset translation to be
allocated.

Fixed: 1170400

Change-Id: I4b057cbcec3a8d72b0beeda7a0f3e34f99a605ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2666949
Commit-Queue: Chris Harrelson \<chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang \<wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#849919}

Change-Id: I9f5e6d769e6b77937541b0aa70e9a164432b4252
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/2671539
WPT-Export-Revision: ccfdda2f53cf76d60b93c05ffc352fefe38d6460

PR 27453 applied with additional changes from upstream: 238b2dfe0fd0519d74df19230ca7cd0793944fc2
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f1e175586115 [wpt PR 27453] - Revert "Store bit for paint offset translation was present before reattach", a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.