Closed Bug 1690473 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27454 - CSS highlight painting: improve WPT cases

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Product:
Core
Component:
Layout: Generated Content, Lists, and Counters
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27454 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27454
Details from upstream follow.

b'Delan Azabani <dazabani@igalia.com>' wrote:

CSS highlight painting: improve WPT cases

This patch:

• renames and updates \<css/css-pseudo/highlight-painting-order.html>
to use selectRangeWith and fix painting order in the reference

• adds \<css/css-pseudo/highlight-painting-002.html> (based mostly on
<https://bucket.daz.cat/work/igalia/0/6.html?wm=vertical-rl&t=quick>
with shadow offsets halved to expose more order violations)

• adds \<css/css-pseudo/highlight-painting-003.html> (checking painting
of backgrounds and decorations on both originating and ::selection;
<https://bucket.daz.cat/fea68658e8009d51.png>)

The first two tests should pass once <https://crrev.com/c/2658617> and
its two dependencies land, though we might need to fix bug 1172177 as
well. The third test is yet to be addressed by any patch, but needs to
pass before we can consider this bug resolved.

Bug: 1147859
Change-Id: I1206b910445332eadd162dd78b0f4bc7fb8d08a3

Reviewed-on: https://chromium-review.googlesource.com/2670609
WPT-Export-Revision: af1aafd2ecc1a77532e885a9078d29ccdb0b2a94

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

FAIL: 3

Chrome

FAIL: 3

Safari

FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/highlight-painting-001.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/highlight-painting-002.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/highlight-painting-003.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fbd54eb5dcc4
[wpt PR 27454] - CSS highlight painting: improve WPT cases, a=testonly
https://hg.mozilla.org/integration/autoland/rev/8058d0fb42be
[wpt PR 27454] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/fbd54eb5dcc4
https://hg.mozilla.org/mozilla-central/rev/8058d0fb42be

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.