Reintroduce synchronous QuotaManager::GetOrCreate
Categories
(Core :: Storage: Quota Manager, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: janv, Assigned: janv)
Details
Attachments
(1 file)
QuotaManager::Init doesn't have to run off the owning thread anymore (after bug 1526891).
However, QuotaManager::GetOrCreate still pretends that the creation must be asynchronous which is not the case anymore. Updating all quota clients is a non-trivial task, so instead of updating everything at once, we can reintroduce synchronous GetOrCreate, and incrementally update clients later.
At this occasion, I'd like to also fix all the xpcshell tests which require QuotaManager, but they don't call do_get_profile which results in a warning. This bug will change it to an assertion.
|
Assignee | |
Comment 1•3 years ago
|
||
Depends on D103791
|
|
Assignee | |
Comment 2•3 years ago
|
||
At this occasion, I'd like to also fix all the xpcshell tests which require QuotaManager, but they don't call
do_get_profilewhich results in a warning. This bug will change it to an assertion.
Unfortunatelly, some webgl generated tests now trigger the assertion:
https://treeherder.mozilla.org/logviewer?job_id=328676751&repo=try&lineNumber=3358
The stack trace is not very helpful, so we will stick with a warning for now.
|
||
Comment 3•3 years ago
|
||
For reference, you saying "reintroduce synchronous GetOrCreate", which implies this had existed before at some time. Could you link the bug that removed that?
|
|
Assignee | |
Comment 4•3 years ago
|
||
(In reply to Simon Giesecke [:sg] [he/him] from comment #3)
For reference, you saying "reintroduce synchronous GetOrCreate", which implies this had existed before at some time. Could you link the bug that removed that?
Bug 961049
Exact changeset: https://hg.mozilla.org/mozilla-central/rev/27a67b5cc5916ac57ca7b64808da50799e0407f0
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e3f866fc70f4 Reintroduce synchronous QuotaManager::GetOrCreate; r=dom-workers-and-storage-reviewers,sg
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Description
•