1690495 - Avoid updating the bookmarks toolbar multiple times when removing bookmarks

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Mark Banner (:standard8)]

Batching of bookmark remove notifications is being added in bug 1607245.

I noticed that BookmarkingUI.handlePlacesEvents will not be very efficient. This is an existing issue, but we can resolve it now due to the added batching:

https://searchfox.org/mozilla-central/rev/b2433a832c250c55255e0ee37d05192d04f20427/browser/base/content/browser-places.js#2355-2358

We should use a flag for the this.maybeShowOtherBookmarksFolder(); call and only execute once after the loop.

Likewise this.updateEmptyToolbarMessage() should only be executed after the loop.

These are both functions which potentially end up with us executing SQL.

I don't think it is worth splitting out the this._updateStar(); that should only be called once per batch.

Whilst here we could also clean up this code to only happen in the following if statement when we're building the bookmarks button:

https://searchfox.org/mozilla-central/rev/b2433a832c250c55255e0ee37d05192d04f20427/browser/base/content/browser-places.js#2452-2453

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1690495: Make bookmarks toolbar to batch update when addition/removal.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7aebb6b02c84
Make bookmarks toolbar to batch update when addition/removal. r=Standard8

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7aebb6b02c84