Closed
Bug 1690553
Opened 4 years ago
Closed 2 years ago
Rust 1.51 unused field warnings-as-errors in marionette.rs
Categories
(Testing :: geckodriver, defect, P3)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: away, Unassigned)
Details
0:27.00 error: field is never read: `protocol`
0:27.00 --> testing\geckodriver\src\marionette.rs:451:5
0:27.00 |
0:27.00 451 | protocol: Option<u16>,
0:27.00 | ^^^^^^^^^^^^^^^^^^^^^
0:27.00 |
0:27.00 = note: `-D dead-code` implied by `-D warnings`
0:27.00 error: field is never read: `application_type`
0:27.00 --> testing\geckodriver\src\marionette.rs:452:5
0:27.00 |
0:27.00 452 | application_type: Option<String>,
0:27.00 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
It's not clear to me as an outsider whether these are intentional. Should they be removed, or should they have annotations to silence the warning?
Comment 1•4 years ago
|
||
These fields are clearly in use so we cannot remove them:
https://searchfox.org/mozilla-central/rev/927e525f481a93a8f63d27a78ae6201e42b1b1fb/testing/geckodriver/src/marionette.rs#1354-1371
Severity: -- → S3
Priority: -- → P3
Comment 2•2 years ago
|
||
I don't see these warnings anymore.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•