Closed
Bug 1690560
Opened 3 years ago
Closed 3 years ago
Close lsArchiveTmpConnection explicitly in QuotaManager::CreateLocalStorageArchiveConnectionFromWebAppsStore
Categories
(Core :: Storage: Quota Manager, task)
Core
Storage: Quota Manager
Tracking
()
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Currently, the lsArchiveTmpConnection is not closed explicitly in QuotaManager::CreateLocalStorageArchiveConnectionFromWebAppsStore, but just by leaving the scope of the nsCOMPtr. However, their might either be other references to the connection, or closing the connection fails for some reason, so it's better to close it explicitly.
We have some reports of NS_ERROR_FILE_IS_LOCKED errors when trying to rename the file after that, which should either be turned into successes by this change, or into failures of closing the connection.
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/512f227f2714 Explicitly close lsArchiveTmpConnection and propagate any errors. r=dom-workers-and-storage-reviewers,janv
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•