1690561 - Adjust content context menu item labels for clarity/brevity

Status: VERIFIED FIXED

(Firefox :: Menus, enhancement, P1)

Description

[:Gijs (out for now; he/him)]

As part of this bug we want to make the following labeling changes:

• Open Link in New Container Tab --> Open Link in New Container

• Copy Link Location --> Copy Link

• Bookmark This Link --> Bookmark Link

• Copy Image Location --> Copy Image Link

• Set As Desktop Background --> Set Image as Desktop Background

• Inspect Element --> Inspect

• "(No spelling suggestions)"; drop parentheses

Comment 1

[Erica Wright [:ewright]]

What about:
"Copy Video Location" and "Copy Audio Location"? I assume the same treatment as "Copy Image Location" by changing "Location" to "Link".

Also, for string changes we are not putting this behind any prefs, correct?

Comment 2

[Erica Wright [:ewright]]

Attachment: Bug 1690561 - Update context menu strings for clarity.

Comment 3

[:Gijs (out for now; he/him)]

(In reply to Erica Wright [:ewright] from comment #1)

What about:
"Copy Video Location" and "Copy Audio Location"? I assume the same treatment as "Copy Image Location" by changing "Location" to "Link".

Yes, sorry, the video/audio changes came through after I filed this bug and I forgot to update it.

Also, for string changes we are not putting this behind any prefs, correct?

Correct!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8804e8807b3
Update context menu strings for clarity. r=Gijs,fluent-reviewers

Comment 5

[Blake Winton (:bwinton) (:☕️)]

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d8804e8807b3

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to :Gijs (he/him) from comment #0)

• Copy Link Location --> Copy Link

This makes the command slightly more ambiguous and the user expectation can be shifted to getting a paste of the link text with the link functionality when pasting in rich text environments.

Comment 9

[afw5059]

with the "Copy Link Location" label changing to "Copy Link" the keyboard shortcut has changed from "A" to "L". Assuming the user is a right-handed mouse user and has their left hand resting naturally on the home row keys, it is inconvenient to move to hit "L" after right clicking links to copy the link.

Would it be possible to revert this label change or at the very least provide a shortcut that is on the left side of the keyboard again? Maybe back to "C" or something? or is this shortcut configurable somehow?

related https://bugzilla.mozilla.org/show_bug.cgi?id=423905

Comment 10

[afw5059]

if "Copy Link Location" is no longer an option, would "Copy Link Address" work in its place? that way the "A" keyboard shortcut could be preserved rather than changing it to "L"

Comment 11

[Bogdan Maris, Desktop Test Engineering]

Verified that the labeling changes from comment 0 and comment 1 are correctly made and they work as expected in latest Nightly 88.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04). I'll close this bug as verified fixed even though it has status affected for firefox87 flag, that was Nightly 87.

Comment 12

[:Gijs (out for now; he/him)]

Thanks!

Comment 14

[Shane Hughes [:aminomancer]]

Hey Gijs should Bookmark This Page and Bookmark This Frame be updated to match the Bookmark Link item resulting from this patch? i.e., to Bookmark Page and Bookmark Frame.

Also do you have an opinion about whether these bookmark menuitems should have ellipses at the end? Francesco noticed that the new bookmark menuitem we just added to the Synced Tabs sidebar context menu is lacking an ellipsis, and I was digging through the equivalent strings and noticed a whole bunch of inconsistencies with bookmark-adding menuitems.

The ones that open an edit bookmark dialog or the edit bookmark panel, that is. It kinda sticks out since in the places menus, if you right-click a bookmark you get menuitems labeled Add Bookmark… and Edit Bookmark… that open the same edit bookmark dialog that the Bookmark Link menuitem opens. So, I thought I might open a new bug for this, unless there's a rationale for omitting the ellipsis?

The Bookmark Tab menuitem in the tab context menu, the Bookmark current tab/Edit this bookmark toolbarbutton in the bookmarks subview in the app menu, and the equivalent menuitems in the menubar's "Bookmarks" menu, are also lacking an ellipsis.

Edit: oh, and this is unrelated but just making a note so I don't forget — "Print Selection" is also lacking an ellipsis, whereas "Print…" always has one.

Comment 15

[:Gijs (out for now; he/him)]

(In reply to Shane Hughes [:aminomancer] from comment #14)

Hey Gijs should Bookmark This Page and Bookmark This Frame be updated to match the Bookmark Link item resulting from this patch? i.e., to Bookmark Page and Bookmark Frame.

Definitely "yes" for the first one, though that is only shown as a tooltip (and accessibility label for screenreaders) on Windows/Linux. On macOS (where we don't have the iconified menu and so show only text) we already say "Bookmark Page", so Windows/Linux should match.

I don't know about the "This Frame" case. Meridel, can you help? You can see this context menu by going to https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_iframe and right clicking in the right hand pane, then checking the "This Frame" submenu. We say "Open Frame in New Tab" (... Window) and "Save Frame As" etc., but say "Bookmark This Frame" and "Show Only This Frame". At least the former sounds like we could just say "Bookmark Frame". I'm not sure what to do with "Show Only This Frame" - I guess we leave it as-is? Time to revive the giant slide decks you had for these menus!

Also do you have an opinion about whether these bookmark menuitems should have ellipses at the end? Francesco noticed that the new bookmark menuitem we just added to the Synced Tabs sidebar context menu is lacking an ellipsis, and I was digging through the equivalent strings and noticed a whole bunch of inconsistencies with bookmark-adding menuitems.

The ones that open an edit bookmark dialog or the edit bookmark panel, that is. It kinda sticks out since in the places menus, if you right-click a bookmark you get menuitems labeled Add Bookmark… and Edit Bookmark… that open the same edit bookmark dialog that the Bookmark Link menuitem opens. So, I thought I might open a new bug for this, unless there's a rationale for omitting the ellipsis?

Yeah... I think it should get an ellipsis, but I'll let Meridel confirm. It's confusing because "Bookmark Page" doesn't open the dialog, it creates the bookmark immediately and opens a panel (which will go away by itself after a few seconds, by default) so there's no ellipsis. Anything that opens an extra dialog and requires confirmation before the action takes effect (like "Bookmark Link") should have an ellipsis. I can only find an internal page with documentation right now; I thought we had a public copy but anyway, the relevant section reads:

Ellipses help telegraph to people that an action they want to execute requires another step before it's completed.
The visual cue offered by an ellipsis allows people to explore your software without fear of taking an action prematurely.

To decide whether a button, link, or menu item needs an ellipses, think about what happens next:

✔ Yes, use an ellipsis when an additional step is required to complete that specific action.
❌ No, don't use an ellipsis if the action displays another window or page from which users can select a variety of actions. [e.g. the app's Settings page]

In this case, we show a dialog and the user has to click [Add] or [Save] before the bookmark is created, whereas the "Bookmark Page" context menu and main menubar menu entry ("Bookmark Current Tab") doesn't require that (it will save the bookmark even if you click out of the popup that appears, and users can turn off that popup appearing altogether).

The Bookmark Tab menuitem in the tab context menu, the Bookmark current tab/Edit this bookmark toolbarbutton in the bookmarks subview in the app menu, and the equivalent menuitems in the menubar's "Bookmarks" menu, are also lacking an ellipsis.

So confusingly I think the main menubar "Bookmark current tab" not having an ellipsis is correct (it bookmarks immediately, even though a popup does show up!), but the tab context menu not having one is incorrect (it opens a dialog that has to be user-confirmed). Still, Meridel gets the last word here...

(I don't know what to do with "Edit this bookmark" in the main menubar... it starts editing the bookmark immediately, but you have to actually edit something and then click "Save" in the panel to make the changes persist, I think.)

Edit: oh, and this is unrelated but just making a note so I don't forget — "Print Selection" is also lacking an ellipsis, whereas "Print…" always has one.

I concur that this probably also wants an ellipsis.

---

In terms of creating a new bug, let's wait for Meridel to reply and then file a new bug with the outcome of that. :-)

Comment 16

[Meridel [:meridel]]

Attachment: August 2022 Label recommendations.png

Hm, it does appear that those bookmark items should have ellipses. We wrote our guidelines after the redesign.

As for the Frames, I don't think the submenu for this was in scope because we didn't make any recommendations but I agree with making one change there.

Here are my recommendations. Please let me know if I missed something...I also have this captured in a new slide in my massive slide deck.

Comment 17

[Shane Hughes [:aminomancer]]

(In reply to Meridel [:meridel] from comment #16)

Here are my recommendations. Please let me know if I missed something...I also have this captured in a new slide in my massive slide deck.

Hey Meridel, in the Frame strings table, by Bookmark Frame do you mean the one that currently says Bookmark This Frame? I mixed this one up in my previous post, but I agree with Gijs that removing "This" would be worthwhile, since the menuitem is inside a This Frame menu, and the other menuitems like Print Frame… omit the "This" string. So would it make sense to change Bookmark This Frame to Bookmark Frame…?

Comment 18

[Meridel [:meridel]]

Good catch, thanks, Shane. Yes, I agree with changing "Bookmark This Frame" to simply "Bookmark Frame."

Comment 19

[Meridel [:meridel]]

Attachment: August 2022 Label Recommendations, New.png

Updated screenshot, adjusting for "Bookmark This Frame"/"Bookmark Frame" recommendation.