Closed Bug 1690575 Opened 10 months ago Closed 9 months ago

Clarify toolbar context menu items

Categories

(Firefox :: Toolbars and Customization, enhancement)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox87 --- wontfix
firefox88 --- verified

People

(Reporter: Gijs, Assigned: mtigley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-context-menus])

Attachments

(1 file)

We want to:

  • rename "Customize..." to "Customize Toolbar..." (this should also affect the main menu)
  • rename "Auto-Hide" for the downloads button to "Hide Button When Empty"
  • hide the pin/remove options and the subsequent separator for flexible spaces (so the menu, when opened there will just show the options to hide/show toolbar(s) and to customize toolbar...)
  • reorder the "Only show on New Tab" item in the bookmarks toolbar submenu to be between "always" and "never", instead of at the end.

rename "Auto-Hide" for the downloads button to "Hide Button When Empty"

Does this mean that the downloads button will always appear if there have been previous (uncleared) downloads?

(In reply to Asif Youssuff from comment #1)

rename "Auto-Hide" for the downloads button to "Hide Button When Empty"

Does this mean that the downloads button will always appear if there have been previous (uncleared) downloads?

This bug doesn't cover any behaviour changes for this item, only labelling changes. I otherwise don't understand the question, but this is probably not the right forum for it either way.

Assignee: nobody → mtigley
Status: NEW → ASSIGNED
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01744b591cf8
Clarify toolbar context menu items. r=Gijs,fluent-reviewers,jaws
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

(In reply to :Gijs (he/him) from comment #0)

  • rename "Auto-Hide" for the downloads button to "Hide Button When Empty"

Note that left-clicking the download button in customize mode still shows "Auto-hide".
https://searchfox.org/mozilla-central/rev/ca22dc040c3a6f9257efdaedec848bb48334f8bd/browser/locales/en-US/chrome/browser/browser.dtd#169
It would be good to make it consistent with the context menu item.

(In reply to Oriol Brufau [:Oriol] from comment #6)

(In reply to :Gijs (he/him) from comment #0)

  • rename "Auto-Hide" for the downloads button to "Hide Button When Empty"

Note that left-clicking the download button in customize mode still shows "Auto-hide".
https://searchfox.org/mozilla-central/rev/ca22dc040c3a6f9257efdaedec848bb48334f8bd/browser/locales/en-US/chrome/browser/browser.dtd#169
It would be good to make it consistent with the context menu item.

Could you file a separate bug? Thanks.

Flags: needinfo?(oriol-bugzilla)

Filed bug 1697830.

Flags: needinfo?(oriol-bugzilla)
Depends on: 1697830

Verified that the changes from comment 0 are correctly seen and their functionality is working as expected in latest Nightly 88.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.