1690630 - Missing Folder Pane mode dropdown toolbar after upgrading to 86

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[wordstar1]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.104 Safari/537.36

Steps to reproduce:

processing daily incoming

Actual results:

want to select 'unread folders' view. the folders view pull-down is gone.

I have to go to main menu-view-folders - check 'unread' to change view

Expected results:

pull down menu, select 'unread'

Comment 1

[Magnus Melin [:mkmelin]]

Not sure which "pull-down you mean". View | Toolbars | Folder pane toolbar
... should have what you need. It's just changed to allow multiple modes.

Comment 2

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: New Folder Pane toolbar with triple-dot dropdown menu (now allows multiple stacked views)

Hey Wordstar, as Magnus said, just use View | Toolbars | Folder pane toolbar to get that toolbar back. The dropdown is now on the three dots, and allows showing multiple views stacked on top of each other. For single view, you need to uncheck all other views and check only the view of your choice.

Comment 3

[Richard Marti (:Paenglab)]

Alessandro, maybe we should add a migration to make the new Folder pane toolbar visible when the old Folder pane toolbar was shown. What do you think?

Comment 4

[Alessandro Castellani [:aleca]]

Indeed, a migration to show the new #fodlerPaneHeader is the old #folderPane-toolbar is not collapsed in the XUL store would be nice.
I'll take care of it.

Comment 5

[Alessandro Castellani [:aleca]]

Attachment: 1690630-folder-modes-dropdown.diff

A simple migration to ensure the visibility of the new folder modes header if the user has the old dropdown visible.

Comment 6

[Alessandro Castellani [:aleca]]

Comment on attachment 9201839 [details] [diff] [review]
1690630-folder-modes-dropdown.diff

Redirecting the review to Geoff since he did something pretty much identical in the previous iteration.

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9201839 [details] [diff] [review]
1690630-folder-modes-dropdown.diff

LGTM!

Comment 8

[Alessandro Castellani [:aleca]]

Comment on attachment 9201839 [details] [diff] [review]
1690630-folder-modes-dropdown.diff

[Approval Request Comment]
Regression caused by (bug #): bug 1163555
User impact if declined: If users have the folder mode dropdown visible before upgrading, they won't automatically see the new Folder mode header and it can be confusing.
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): low as it's just a migration of the stored XUL property.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/90018ca123b6
Migrate old Folder pane mode dropdown to new header. r=darktrojan

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9201839 [details] [diff] [review]
1690630-folder-modes-dropdown.diff

[Triage Comment]
Approved for beta

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 86.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/1c5671e53940

Comment 12

[WaltS48 [:walts48]]

TB 86.0b3 on Win10