1690769 - [wpt-sync] Sync PR 25198 - Added 2 grammar-spelling-* tests

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 25198 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25198
Details from upstream follow.

b'G\xc3\xa9rard Talbot <[e-mail]>' wrote:

Added 2 grammar-spelling-* tests

This is a followup to
https://github.com/web-platform-tests/wpt/pull/21862

grammar-spelling-errors-001.html
reference/grammar-spelling-errors-001-ref.html
grammar-spelling-errors-002.html
reference/grammar-spelling-errors-002-ref.html

Your comments in PR21862 were:

{

• Afaict it's not possible to have a visible caret in the middle of a highlighted word. So I'm not sure the active-selection-005 case is actually testable. We might need to skip the ::selection case, and only test caret-color for spelling and grammar errors.
• Afaict, the contenteditable element needs to be focused in order for the spelling error to be visible in Firefox and Chrome. We should do that with JS, and adjust the instructions to clarify that the contenteditable needs to be active for the test to work.
• Both 001 and 002 test that both the color and background of ::grammar-error is overridden by ::spelling-error. But we don't have a test for a combined result. If in 001 you move 'color: green' from ::spelling-error to ::grammar-error (and leave it unspecified for ::spelling-error), and in 002 you move 'background: yellow' from ::spelling-error to ::grammar-error (and leave it unspecified for ::spelling-error), then the tests will check that both ::spelling-error and ::grammar-error are correctly applied, and that ::spelling-error overrides ::grammar-error where there's a conflict (but not otherwise).

}

[Update 20210113]
Issue 4100 has dropped, removed 'caret-color' from 3.2 Styling Highlights
[/Update 20210113]

On my website, the files are:

http://www.gtalbot.org/BrowserBugsSection/CSS4Pseudo/grammar-spelling-errors-001.html

http://www.gtalbot.org/BrowserBugsSection/CSS4Pseudo/reference/grammar-spelling-errors-001-ref.html

http://www.gtalbot.org/BrowserBugsSection/CSS4Pseudo/grammar-spelling-errors-002.html

http://www.gtalbot.org/BrowserBugsSection/CSS4Pseudo/reference/grammar-spelling-errors-002-ref.html

http://www.gtalbot.org/BrowserBugsSection/CSS4Pseudo/spelling-error-004-manual.html

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a355b89eb4ab69b207b515b6cc9c7d5e1337f0a2

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63cf7f490100
[wpt PR 25198] - Added 2 grammar-spelling-* tests, a=testonly

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/63cf7f490100