Closed Bug 1690831 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27483 - Define blink::mojom::KeepAliveHandleFactory

Categories

(Core :: DOM: Networking, task, P4)

Product:
Core
Component:
DOM: Networking
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27483 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27483
Details from upstream follow.

b'Yutaka Hirano <yhirano@chromium.org>' wrote:

Define blink::mojom::KeepAliveHandleFactory

We've used blink::mojom::LocalFrameHost to issue KeepAliveHandles for
requests with keepalive set. That doesn't work for keepalive requests
initiated in unload handlers in nested frames, because the
RenderFrameHost object is destructed without waiting for the end of
unload handlers.

This CL defines a separate interface, KeepAliveHandleFactory. The
renderer side gets a mojo::Remote for KeepAliveHandleFactory long before
the frame is destructed, in order to avoid the above problem.

Bug: 1161196
Change-Id: I92ef0073548d8755e42bc69f957e518a73d9e52a
Reviewed-on: https://chromium-review.googlesource.com/2675428
WPT-Export-Revision: 230572e761162592adb60e1753f1d322f02af697

Component: web-platform-tests → DOM: Networking
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
PASS: 4
FAIL: 4

Chrome

OK : 1
PASS: 7
FAIL: 1

Safari

OK : 1
PASS: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/fetch/api/basic/keepalive.html
same-origin: FAIL
cross-origin redirect: FAIL
cross-origin redirect with preflight: FAIL

New Tests That Don't Pass

/fetch/api/basic/keepalive.html
same-origin: FAIL (Chrome: PASS, Safari: PASS)
cross-origin redirect: FAIL (Chrome: PASS, Safari: PASS)
cross-origin redirect with preflight: FAIL (Chrome: PASS, Safari: PASS)
keepalive in onunload in nested frame in another window: FAIL (Chrome: FAIL, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/64c5121bf465
[wpt PR 27483] - Define blink::mojom::KeepAliveHandleFactory, a=testonly
https://hg.mozilla.org/integration/autoland/rev/474582099871
[wpt PR 27483] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/64c5121bf465
https://hg.mozilla.org/mozilla-central/rev/474582099871

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.