1690845 - File with no extension uses icon for C: drive

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Attachment: drive icon dialog.png

STR:

1. Click a link to open a file that will be saved with no extension, example octet-stream just called "test".
2. In the unknown content type dialog the icon shown will be that for the C: drive itself.
3. Save the file.
4. The icon shown in the downloads panel will be the same C: drive icon.

I'm pretty sure it's for the C: drive and not just some default icon, because it shows up differently on different machines, consistent with how C: appears in Explorer (e.g. with BitLocker, across Win 7 and Win 10). Even if the file is saved to an external drive with a different icon, the C: icon is used in both the dialog and the panel.

This isn't new, I found it going back at least to 2018. Sorry if it's already filed but I couldn't find a previous example.

Comment 1

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Also note that this is different from the behavior for an unknown extension, which shows a "blank page" icon, probably that's the one we should be using.

Comment 2

[:Gijs (he/him)]

Believe it or not, this is moz-icon code and it lives in imagelib.

The problem is that we'll try to create an icon with moz-icon://test?size=16&contentType=application/octet-stream and either the nsIconURI.cpp or the windows implementation of nsIconChannel.cpp does not deal well with the leafname not having an extension.

Comment 3

[Timothy Nikkel (:tnikkel)]

This code seems like it could not deal with not having an extension maybe
https://searchfox.org/mozilla-central/rev/8432d4fe31245ae9121231d7c0335aaa342675d2/image/decoders/icon/win/nsIconChannel.cpp#449

Comment 4

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1690845. Don't ask Windows for the icon of an empty file extension because it returns the c: drive icon, which is not what we want. r?gijs

The tests I added pass before and after this patch. I couldn't figure out a way to write a test that failed before.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ff45a9b57fe
Don't ask Windows for the icon of an empty file extension because it returns the c: drive icon, which is not what we want. r=Gijs

Comment 6

[Atila Butkovits]

Backed out for causing failure at reftest.list.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b508157c9213b7237a7d600b8b98359fbd4067d5

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=PuqtneIGQ6WJi27wN9PfEw.0&revision=1ff45a9b57febbac02ac7ccaf03543a27748441e&searchStr=OS%2CX%2C10.14%2CWebRender%2Cdebug%2CReftests%2Ctest-macosx1014-64-qr%2Fdebug-reftest-e10s%2CR1

Failure log: https://treeherder.mozilla.org/logviewer?job_id=331003875&repo=autoland&lineNumber=1503

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a63e14d399f7
Don't ask Windows for the icon of an empty file extension because it returns the c: drive icon, which is not what we want. r=Gijs

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a63e14d399f7