Closed Bug 1690914 Opened 5 years ago Closed 5 years ago

Exempt locale leaders and KB reviewers from link filter

Categories

(support.mozilla.org :: Questions, enhancement)

Product:
support.mozilla.org
Component:
Questions
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: cilias, Assigned: tasos)

References

Details

Discussion: https://support.mozilla.org/en-US/forums/contributors/714221?last=80609&page=8#post-80609

I think it's safe to say that we trust Locale Leaders not to post spam. :)

See Also: → 1675424
See Also: → 1686404
See Also: → 1691380

So, there are multiple things here that I think have the same goal to make the link filtering to be more effective and less time-consuming:

a. Exempt Locale Leaders group from link filtering https://support.mozilla.org/en-US/groups/sumo-locale-leaders
b. Exempt KB Reviewers group from link filtering https://support.mozilla.org/en-US/groups/knowledge-base-reviewers
c. Exempt question owner from link filtering
d. Allow moderators to add a new contributor to the Trusted Contributor group.

The way I see it, doing C & D would be enough since we can then easily add locale leaders or kb reviewers as well as other contributors who contribute to the forum regularly. Not saying that the others are not important but given our limited resources, it's better if we can also learn to prioritize our needs.

How do you both think?

Sounds good to me

Whatever you decide, but D. (bug 1686404) would require individual moderator action for each affected user, assuming permission can be granted (does bug 1463526 comment 14 apply?). A and B would automatically exempt users in those groups from the link filter.

To Kiki: The Locale Leaders and KB Reviewers groups are not that large. Assuming this bug and bug 1691380 will not be fixed any time soon:
If you have some free time maybe you can manually go through https://support.mozilla.org/en-US/groups/sumo-locale-leaders and https://support.mozilla.org/en-US/groups/knowledge-base-reviewers to manually add those users to the Trusted Contributors group.

(from comment #4)

To Kiki: The Locale Leaders and KB Reviewers groups are not that large.

There are actually two groups of KB article reviewers:
https://support.mozilla.org/en-US/groups/knowledge-base-reviewers Reviewers of the English Knowledge Base
https://support.mozilla.org/en-US/groups/reviewers All KB article reviewers (includes all locales).

Posting in this bug as per Sumo request.
The big ongoing issue from a Support point of view which I'm experiencing on a continual basis, is that even after messages from a user eg: the person who asked the question in the first place, have been vetted and display in the forum, I am not receiving any emails regarding the comments that were vetted and posted. I'm not talking about minutes difference, I'm talking about 16 hours plus. I'm missing comments/reponses to requests for information when helping in the forum. I've missed several where people are waiting for a coupe of days and I've had to appologise for the delay in my response and it was not even my fault. I've just discovered another one that is currently 24 hours ago.

Getting emails when people post comments/responses is important. Comments that do not get vetted for spam are received as emails.
Support relies on communication.

Whether some people are exempt or not makes little difference if vetted emails are only being posted in the forum and not being communicated to those following the question. This is the area that needs attention.

(In reply to Anje from comment #6)

The big ongoing issue from a Support point of view which I'm experiencing on a continual basis, is that even after messages from a user eg: the person who asked the question in the first place, have been vetted and display in the forum, I am not receiving any emails regarding the comments that were vetted and posted.

The lack of email notifications after a reply is vetted is bug 1665113.

The following PR excludes the groups mentioned in options a and b from the spam filtering.

My concern with option c is that it will allow spammers to post questions without any checks.

https://github.com/mozilla/kitsune/pull/4697

Assignee: nobody → tasos
Status: NEW → ASSIGNED

(In reply to Tasos Katsoulas [:tasos] from comment #8)

The following PR excludes the groups mentioned in options a and b from the spam filtering.

My concern with option c is that it will allow spammers to post questions without any checks.

https://github.com/mozilla/kitsune/pull/4697

On Option b: Are you exempting both KB reviewer groups?
(from comment #5)
There are actually two groups of KB article reviewers:
https://support.mozilla.org/en-US/groups/knowledge-base-reviewers Reviewers of the English Knowledge Base
https://support.mozilla.org/en-US/groups/reviewers All KB article reviewers (includes all locales)

Option c is a separate bug. See bug 1675424 comment 1:
The question owner is already exempted from the link filter, but only in their initial post. If the same link is posted by the question owner as a reply, the post is held for moderator approval. I tested this with a standard SuMo user account: https://support.mozilla.org/en-US/questions/1311997
Related discussion: https://support.mozilla.org/en-US/forums/contributors/714221?page=8#post-79977

Summary: Exempt locale leaders from link filter → Exempt locale leaders and KB reviewers from link filter

(In reply to Alice Wyman from comment #10)

On Option b: Are you exempting both KB reviewer groups?
(from comment #5)
There are actually two groups of KB article reviewers:
https://support.mozilla.org/en-US/groups/knowledge-base-reviewers Reviewers of the English Knowledge Base
https://support.mozilla.org/en-US/groups/reviewers All KB article reviewers (includes all locales)

Yes, both groups are exempted from the spam filter.

Option c is a separate bug. See bug 1675424 comment 1:
The question owner is already exempted from the link filter, but only in their initial post. If the same link is posted by the question owner as a reply, the post is held for moderator approval. I tested this with a standard SuMo user account: https://support.mozilla.org/en-US/questions/1311997
Related discussion: https://support.mozilla.org/en-US/forums/contributors/714221?page=8#post-79977

Let me dive into that and I will comment back here

Following up on this, I opened a PR to exempt the question owner from spam filtering (linked in the relevant bug)

Changes have been deployed to prod.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

Does this fix or the fix for bug 1675424 have anything to do with reports of trusted contributors no longer being exempted from the spam link filter? Related discussion:
https://support.mozilla.org/en-US/forums/contributors/714933 Reply blocked by spam filter
https://support.mozilla.org/en-US/forums/forum-moderators/714934 some answers by jscher2000 and fredmcd-hotmail are marked as spam

Should a new bug report be filed?

Flags: needinfo?(tasos)

https://github.com/mozilla/sumo-project/issues/804 [regression] Posts from trusted contributors are marked as spam

Flags: needinfo?(tasos)

Thanks Alice for flagging this.

A new patch will be deployed on prod on Tuesday, 23rd of March. In the meantime we added contributors in an exempted group as a temporary workaround. Please let me know if more people should be added in that group until Tuesday.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

A patch has been deployed to prod.

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.