1690987 - Action popups remain empty on Mac

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P2)

Description

[John Bieling (:TbSync)]

With e10s enabled, all action popups show empty pages, no text or icons are loaded. There seems to be some sort of rendering, as the size of the popup is different for different html pages loaded.

This happens on mac. Confirmed with Catalina.
I did not see this on Windows or Linux.

If I flip browser.tabs.remote.autostart popups work again as expected.

Comment 1

[sbean]

The issue is present with Thunderbird 91 b1 on Big Sur

Comment 2

[John Bieling (:TbSync)]

My mac is broken, but this seems to be related to fission. An idea?

Comment 3

[John Bieling (:TbSync)]

Attachment: action_popup.xpi

A simple add-on which adds an action button with a popup.

Comment 4

[John Bieling (:TbSync)]

Attachment: grafik.png

This is how it should look.

Comment 5

[:Dossy Shiobara]

Attachment: Screen Shot 2021-07-17 at 10.22.34 AM.png

This is on macOS 10.15.7 Catalina with 78.11.0 (64-bit). Appears to work as expected.

Comment 6

[John Bieling (:TbSync)]

This seems to fail on mac after fission was enabled, beta 86 and later. Does it work for you on Beta?

Comment 7

[Wayne Mery (:wsmwk)]

I currently can't test this because of bug 1674954

Comment 8

[Geoff Lankow (:darktrojan)]

Updating ExtensionPopups.jsm seems to fix it. I don't know which change caused the breakage, or why it only seems to affect Mac, and I'm not going to investigate further as long as it works.

Comment 9

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1690987 - Update extension popup code from mozilla-central. r=john.bieling

This makes our code quite a bit closer to the same code in Firefox, plus it fixes the problem on macOS.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cc42a89b2d2d
Update extension popup code from mozilla-central. r=john.bieling

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/11e13722c30d
follow-up - Fix some broken tests. rs=bustage-fix

Comment 12

[John Bieling (:TbSync)]

Comment on attachment 9232098 [details]
Bug 1690987 - Update extension popup code from mozilla-central. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Mac users cannot use action popups.

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Low.

Please also uplift Geoffs bustage-fix.

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9232098 [details]
Bug 1690987 - Update extension popup code from mozilla-central. r=john.bieling

[Triage Comment]
Approved for beta

Comment 14

[Dave Miller [:justdave]]

Thunderbird 91.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/00bd6e8547fb
https://hg.mozilla.org/releases/comm-beta/rev/09f937ffc744

Comment 15

[sbean]

On Thunderbird 91.0b6, the problem is not completely fixed.

The popup content appeared just for the first time. The popup remains empty afterward.

Comment 16

[sbean]

Attachment: Example.xpi

Comment 18

[sbean]

(In reply to sbean from comment #15)

On Thunderbird 91.0b6, the problem is not completely fixed.

The popup content appeared just for the first time. The popup remains empty afterward.

Comment 19

[Magnus Melin [:mkmelin]]

Please don't touch the flags. If something is not working, open a new bug. This is closed and uplifted across branches.

Comment 20

[John Bieling (:TbSync)]

Bug regarding popup being empty on second click is bug 1725630.