Closed Bug 1691086 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27510 - [shadow-dom] shadow-dom/nested-slot-remove-crash.html should use `let` instead of `const` to declare variables

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27510 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27510
Details from upstream follow.

b'Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com>' wrote:

[shadow-dom] shadow-dom/nested-slot-remove-crash.html should use let instead of const to declare variables

I cannot see https://crbug.com/1159328 by the permission problem, so I'm not sure about the original details. However, from the code comment, I doubt the current code does not works as intended.

  1. If this code runs on Chromium/Firefox/WebKit, this test does not crash.
  2. But by the browser's developer tools console, the execution is stopped at https://github.com/web-platform-tests/wpt/blob/0fa6dc568c006811e1fc0035d3b9c70dd7efadf5/shadow-dom/nested-slot-remove-crash.html#L30 by SyntaxError.
  3. By pull requests which imported this tests (https://github.com/web-platform-tests/wpt/pull/26951, https://github.com/web-platform-tests/wpt/pull/27001), I feel their original bug is related to DOM.

So I think this root should be declare by let instead of const.

Is this guess right?

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/231e9e2b8cdc
[wpt PR 27510] - [shadow-dom] shadow-dom/nested-slot-remove-crash.html should use `let` instead of `const` to declare variables, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eda94059722d
[wpt PR 27510] - [shadow-dom] shadow-dom/nested-slot-remove-crash.html should use `let` instead of `const` to declare variables, a=testonly

https://hg.mozilla.org/mozilla-central/rev/eda94059722d

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.