1691129 - Task list: Priority icon (!) in column header horizontally misaligned with priority icons in the list

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect, P3)

Description

[Tim]

Attachment: icons-alignment.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.150 Safari/537.36

Steps to reproduce:

Simply have the Today Pane open on the right side, with the list of tasks in view. Look at the priority icons (e.g. exclamation mark, arrows, etc).

Actual results:

The icons are not horizontally aligned. There's about a 2-3 pixel shift between the exclamation icon in the header, and the icons listed below for each task entry.

Expected results:

I expect the priority icons to be horizontally aligned with no pixel shift.

Comment 1

[Thomas D. (:thomas8)]

Attachment: Screenshot 2: Correct alignment on Win10 / 78.7.0 (64-bit)

Wfm on Win10, 78.7.0 (64-bit), but reported against Mac I believe...

Comment 2

[Thomas D. (:thomas8)]

tzhu07, can you confirm your OS and the exact TB version on which you have seen this?

Also, "Click here to add a new task" is in a non-default position, below the list. Are you using addons?

Does this little issue occur after ≡ > Help > Restart with Add-ons Disabled…?

Comment 3

[Tim]

My OS is Windows 10, version 20H2, build 19042.746.

Exact TB version is 78.7.1 (32-bit).

I'm not using any addons that would affect the layout. My screenshot is taken from the Today Pane, which is a minified version of the task list. Restarting with addons disabled doesn't fix the issue.

Your screenshot is taken from the Tasks tab, so if you want to compare apples to apples, the issue still exists on my end. See my screenshot "still-misaligned".

Comment 4

[Tim]

Attachment: still-misaligned.png

Comment 5

[Alessandro Castellani [:aleca]]

I can confirm this, it happens also on Linux.
The wrong alignment is related to the icon used in the column header.
Richard, would you be able to take care of this?

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1691129-align-priority-icon.patch

This fixes it for me. Linux is a bit special as the different Linux themes can style the column header differently. On Ubuntu it's for me aligned correctly.

Additionally I found that the main tree attachment icon on Linux wasn't correctly aligned. Now it should be.

Comment 7

[Alessandro Castellani [:aleca]]

Comment on attachment 9201601 [details] [diff] [review]
1691129-align-priority-icon.patch

Review of attachment 9201601 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/81f6f1389cf3
Align the priority column header icon with the icon in the tree. r=aleca

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 9201601 [details] [diff] [review]
1691129-align-priority-icon.patch

[Approval Request Comment]
User impact if declined: Not well aligned tree column header icon
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9201601 [details] [diff] [review]
1691129-align-priority-icon.patch

[Triage Comment]
Approved for beta

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 86.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/01b77b6f59bc

Comment 12

[WaltS48 [:walts48]]

Attachment: still-offset.png

Not fixed in TB 86.0b3 on Win10.

Comment 13

[WaltS48 [:walts48]]

It appears to have fixed itself after a restart.
TB 86.0b3 on Windows 10

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9201601 [details] [diff] [review]
1691129-align-priority-icon.patch

[Triage Comment]
Approved for esr78

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 78.8.0:
https://hg.mozilla.org/releases/comm-esr78/rev/084ec6fcedd8

Comment 16

[WaltS48 [:walts48]]

Works for me in my tests of the 78.8.0 release candidate on Fedora 33 Workstation and Windows 10.